Re: [PATCH] for xend init script and xend python script

[ShaunR <mailinglists@unix-scripts.com>]

On 10/26/2010 9:21 AM, Ian Jackson wrote:
 > ShaunR writes ("[Xen-devel] [PATCH] for xend init script and xend 
python script"):
 >> This patch does the following, hopefully it will be added to future
 >> versions.
 >>
 >> * xend init script will now send SIGINT to xenconsoled when stop is
 >> issued so that the xenconsoled daemon is also stopped (this is required
 >> if the new options below are added to /etc/sysconfig/xend
 >
 > This is handled by a new "xencommons" script in xen-unstable
 > I think ?

Actually looks like it, i didnt check unstable sorry.

 >
 >> * /etc/sysconfig/xend has additional these additional cosnole options
 >> since the xend init script starts xenconsoled.
 >> 	XENCONSOLED_LOG=(none|guest|hv|all)
 >> 	XENCONSOLED_LOGDIR=PATH
 >> 	XENCONSOLED_TIMESTAMP=(none|guest|hv|all)
 >> 	XENCONSOLED_OVERFLOW=(discard|keep)
 >> 	XENCONSOLED_PIDFILE=PATH
 >
 > Perhaps it would be better to have a single XENCONSOLED_OPTIONS
 > variable ?

I see in the new xencommons that there's a XENCONSOLED_ARGS env which 
could hold all this info and be set in /etc/sysconfig/xencommons but I'm 
worried about it being overwritten by some of the checks in the script.

  69         echo Starting xenconsoled...
  70         test -z "$XENCONSOLED_TRACE" || XENCONSOLED_ARGS=" 
--log=$XENCONSOLED_TRACE"
  71         xenconsoled --pid-file=$XENCONSOLED_PIDFILE $XENCONSOLED_ARGS
  72         test -z "$XENBACKENDD_DEBUG" || XENBACKENDD_ARGS="-d"
  73         test "`uname`" != "NetBSD" || xenbackendd $XENBACKENDD_ARGS
  74 }


Either way works i guess, i like separate options because i think it's 
easier for people to write automated scripts against to ensure the 
options they want are enabled.

Thanks!

~Shaun