All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: device-mapper development <dm-devel@redhat.com>
Cc: "Chauhan, Vijay" <Vijay.Chauhan@lsi.com>,
	James Bottomley <jejb@kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [dm-devel] [RESUBMIT][Patch] scsi_dh_rdac: retry IO for 06/3f/03 in rdac_check_sense fn
Date: Tue, 26 Oct 2010 14:18:54 -0500	[thread overview]
Message-ID: <4CC7299E.2030508@cs.wisc.edu> (raw)
In-Reply-To: <B2FD678A64EAAD45B089B123FDFC3ED704BFE578@inbmail01.lsi.com>

On 10/26/2010 08:53 AM, Chauhan, Vijay wrote:
> Resubmitting this patch to get the attention.
>
> This patch adds retry for the IO returned with 06/3f/03((INQUIRY_DATA_CHANGED)) sense code  in rdac_check_sense(). IO returned with 06/3f/03 from controller are currently failed by scsi mid layer, as a reason momentarily path failure is noticed by DM multipath.
>

Is it getting failed by accident? In scsi_io_completion we check for UAs 
and will retry if the removable bit is not set. That check is after 
scsi_end_request though (is the scsi_end_request call failing the IO).

Did you guys also want REPORTED_LUNS_DATA_HAS_CHANGED to be retried too. 
I think scsi_dh_alua's REPORTED_LUNS_DATA_HAS_CHANGED maybe should be 
genericly retried, because it seems for both errors we will want to 
retry for all devices.

  parent reply	other threads:[~2010-10-26 19:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 13:53 [RESUBMIT][Patch] scsi_dh_rdac: retry IO for 06/3f/03 in rdac_check_sense fn Chauhan, Vijay
2010-10-26 18:55 ` Malahal Naineni
2010-10-26 19:18 ` Mike Christie [this message]
2010-10-26 19:21   ` [dm-devel] " James Bottomley
2010-10-26 19:32     ` Shyam_Iyer
2010-10-26 19:58       ` James Bottomley
2010-10-26 20:27         ` Shyam_Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC7299E.2030508@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=Vijay.Chauhan@lsi.com \
    --cc=dm-devel@redhat.com \
    --cc=jejb@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.