From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch hail] remove duplicated stc_readport Date: Tue, 26 Oct 2010 17:33:13 -0400 Message-ID: <4CC74919.4030307@garzik.org> References: <20101026134708.1bb36aca@lembas.zaitcev.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=W4sFdSWGnpE7dDaTlREYONAgvpVfL30dZlZa3nc1XDY=; b=VV8niraWRXvLJnZTFStgrFI1XBI81wET7k0dC6XsafKEongpOxZtT4iXT7pBxIdylt jwZpHIsxrvp2Yu91In4fmqeikuEA57HCdo1uDuSbabgUlhKzHwdoudXpce4VPt6ynAPN L3A+AVDwvjaUZsf+PQw1xxPbQIoxacw+Vn2R8= In-Reply-To: <20101026134708.1bb36aca@lembas.zaitcev.lan> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 10/26/2010 03:47 PM, Pete Zaitcev wrote: > Now that we have a common library for Hail, an opportunity opens to trim > some duplication, such as stc_readport. It even had a comment about it. > > Note that we leave cld_readport in the API for a few weeks, while I get > my tabled trees and RPMs in order. Unfortunately we routinely neglect > to set specific version in RPM headers (e.g. no Requires: cld>= 0.8.2). > > Also, get rid of g_file_get_contents. Talk about pointless: it requires > caller to free memory, and it's not like code is any more compact or > easier to understand. > > Signed-off-by: Pete Zaitcev applied it would be nice if a follow-up patch moved the hail_readport() definition into a more generic, not-CLD-specific header such as include/hail.h[1] Jeff [1] which doesn't exist yet. maybe we could rename hail_log.h to hail.h, and make hail.h a dumping ground for hail-generic items.