All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [GIT PULL] fix for loop warning
Date: Tue, 26 Oct 2010 22:18:17 -0600	[thread overview]
Message-ID: <4CC7A809.1070607@fusionio.com> (raw)

Hi Linus,

One-liner fix for a warning regression introduced with the
loop changes pulled for 2.6.37-rc1

Please pull.

The following changes since commit 9db59aff3fb32b05a7e2464dd543de03b2b3cebc:

  loop: Properly clear sysfs in autoclear mode (2010-10-26 22:13:27 -0600)

are available in the git repository at:

  git://git.kernel.dk/linux-2.6-block.git for-linus

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1e5284e..450c958 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
-	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
+		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}

-- 
Jens Axboe


             reply	other threads:[~2010-10-27  4:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27  4:18 Jens Axboe [this message]
2010-10-28  1:47 ` [GIT PULL] fix for loop warning Linus Torvalds
2010-10-28 13:32   ` Jens Axboe
2010-10-28 11:38 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC7A809.1070607@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.