All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm, omap3, beagle: initial stack pointer setup
Date: Wed, 27 Oct 2010 15:04:06 +0200	[thread overview]
Message-ID: <4CC82346.5010906@denx.de> (raw)
In-Reply-To: <1288184007.2342.118.camel@quadra>

Hello Steve,

Steve Sakoman wrote:
> On Wed, 2010-10-27 at 14:23 +0200, Heiko Schocher wrote:
>> Hello Steve,
>>
>> Steve Sakoman wrote:
>>> On Wed, 2010-10-27 at 09:14 +0200, Wolfgang Denk wrote:
>>>> Dear Heiko Schocher,
>>>>
>>>> In message <4CC7C628.70402@denx.de> you wrote:
>>>>> CONFIG_SYS_INIT_RAM_ADDR	(SRAM_VECT_CODE)
>>>>>                                  ^
>>>>>                                  0x4020f800
>>>>> CONFIG_SYS_INIT_RAM_SIZE	0x7f0
>>>> Why that? From the current settings I would expect something like
>>>>
>>>> 	CONFIG_SYS_INIT_RAM_ADDR	0x4020f800
>>>> 	CONFIG_SYS_INIT_RAM_SIZE	0x800
>>>>
>>>> I see no reason to substract the top 16 bytes?
>>> Agreed.  I saw this issue last night, but didn't have enough time to
>>> prepare a fix.
>>>
>>> I'll generate and test a patch on the OMAP boards which have implemented
>>> relocation.
>> Ok, thanks!
> 
> Now that I have some coffee, I think I see the actual reason that the
> build was broken.
> 
> If you look at the error output:
> 
> start.S: Assembler messages:
> start.S:175: Error: missing ')'
> start.S:175: Error: missing ')'
> start.S:175: Error: garbage following instruction -- `ldr sp,=((0x4020f800+0x800-#96))'
> 
> It is apparent that the assembler does not like that GENERATED_GBL_DATA_SIZE is defined as "#96"
> 
> I tried without the # symbol and the build completes successfully.

Already fixed here:

http://lists.denx.de/pipermail/u-boot/2010-October/080455.html

> I'll prepare a patch to use CONFIG_SYS_INIT_RAM_ADDR and
> CONFIG_SYS_INIT_RAM_SIZE on the OMAP boards with relocation, because
> that is still a good idea, but we also need to deal with the prepended #
> symbol.

Ok, thanks.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2010-10-27 13:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27  6:26 [U-Boot] arm, omap3, beagle: initial stack pointer setup Heiko Schocher
2010-10-27  7:14 ` Wolfgang Denk
2010-10-27 12:12   ` Steve Sakoman
2010-10-27 12:23     ` Heiko Schocher
2010-10-27 12:53       ` Steve Sakoman
2010-10-27 13:04         ` Heiko Schocher [this message]
2010-10-27 12:29     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC82346.5010906@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.