All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] xl: fix ballooning
Date: Wed, 27 Oct 2010 15:46:18 +0200	[thread overview]
Message-ID: <4CC82D2A.10704@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Hi,

we should only check the value of new_target_memkb _after_ it has
been properly setup. This fixes ballooning Dom0, which
was broken since 22200:49a3c1721734.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

[-- Attachment #2: fix_xl_ballooning.patch --]
[-- Type: text/x-patch, Size: 877 bytes --]

diff -r cd193fa265b8 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Tue Oct 26 12:22:52 2010 +0100
+++ b/tools/libxl/libxl.c	Wed Oct 27 13:47:05 2010 +0200
@@ -2927,6 +2927,11 @@
         abort = 1;
         goto out;
     }
+    if (relative)
+        new_target_memkb = current_target_memkb + target_memkb;
+    else
+        new_target_memkb = target_memkb;
+
     if (!domid && new_target_memkb < LIBXL_MIN_DOM0_MEM) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "new target for dom0 is below the minimum threshold\n");
@@ -2934,10 +2939,6 @@
         goto out;
     }
 
-    if (relative)
-        new_target_memkb = current_target_memkb + target_memkb;
-    else
-        new_target_memkb = target_memkb;
     if (new_target_memkb > memorykb) {
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
                 "memory_dynamic_max must be less than or equal to"

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-10-27 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 13:46 Andre Przywara [this message]
2010-10-27 13:54 ` [PATCH] xl: fix ballooning Gianni Tedesco
2010-10-28  9:21   ` Andre Przywara
2010-10-28 10:15     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC82D2A.10704@amd.com \
    --to=andre.przywara@amd.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.