All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] imx25: Fix reset
Date: Wed, 27 Oct 2010 17:29:11 +0200	[thread overview]
Message-ID: <4CC84547.50805@denx.de> (raw)
In-Reply-To: <4CC83AA2.2070900@emk-elektronik.de>

On 10/27/2010 04:43 PM, Reinhard Meyer wrote:
> Dear Matthias Weisser,
>>  struct wdog_regs {
>> -	u32 wcr;	/* Control */
>> -	u32 wsr;	/* Service */
>> -	u32 wrsr;	/* Reset Status */
>> -	u32 wicr;	/* Interrupt Control */
>> -	u32 wmcr;	/* Misc Control */
>> +	u16 wcr;	/* Control */
>> +	u16 wsr;	/* Service */
>> +	u16 wrsr;	/* Reset Status */
>> +	u16 wicr;	/* Interrupt Control */
>> +	u16 wmcr;	/* Misc Control */
>>  };
> What catches my ARM-aware eye:
> 
> I do not know the hardware, but are those registers really
> arranged on 2 byte boundaries (00, 02, 04, 06, 08, 0a, .. offsets)?
> Probably yes, assuming your code is tested ;)

Yes, they are. It sounds strange, but they are 16-bit wide.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-10-27 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 14:34 [U-Boot] [PATCH V3] imx25: Fix reset Matthias Weisser
2010-10-27 14:43 ` Reinhard Meyer
2010-10-27 15:29   ` Stefano Babic [this message]
2010-10-27 15:33   ` Matthias Weißer
2010-10-28 11:18 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC84547.50805@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.