Re: [PATCH] calypsomodem: Notify core about commands handled in modem.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Hi Andrew,

>  	/*
> -	 * Proactive command has been handled by the modem.  Should
> -	 * the core be notified?  For now we just ignore it because
> -	 * we must not respond to the command.
> +	 * A proactive command starts with a Proactive UICC Command BER-TLV
> +	 * short tag (0xd0) with optional pad bytes, a Terminal Response
> +	 * starts with the Command Details CTLV tag (0x81).
>  	 */
> +	if (pdu[0] != 0x81)
> +		ofono_stk_proactive_command_handled_notify(stk, len, pdu);
> +	else
> +		ofono_stk_terminal_response_sent_notify(stk, len, pdu);
>  }

I removed terminal_response_sent_notify from the API and took care of
this in the core.  I also went ahead and fixed up the three drivers in
question.  Can you double check that I didn't screw this up?

Thanks,
-Denis