From: Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Cc: Hans Schillstrom <hans.schillstrom@ericsson.com>,
lvs-devel@vger.kernel.org, ja@ssi.bg, wensong@linux-vs.org
Subject: Re: [PATCH] IPVS: ip_vs_pe.c, use strncmp to be safe.
Date: Thu, 28 Oct 2010 12:33:27 +0200 [thread overview]
Message-ID: <4CC95177.1060008@trash.net> (raw)
In-Reply-To: <20101028075650.GC5305@verge.net.au>
On 28.10.2010 09:56, Simon Horman wrote:
> On Wed, Oct 27, 2010 at 05:05:00PM +0200, Hans Schillstrom wrote:
>> With pe data traveling between master and backup,
>> strcmp should not be used.
>> How knows what size it will have in future.
>>
>> To be safe use strncmp.
>
> Hi Hans,
>
> I'm not entirely convinced this is necessary, but
> its better to be safe than sorry.
>
>> Signed-off-by: Hans Schillstrom <hans.schillstrom@ericsson.com>
>
> Patrick, I assume that nf-next-2.6 is currently closed.
> I'll push this to you once it opens again.
Thanks, I'll open up nf-next once Dave opens net-next.
prev parent reply other threads:[~2010-10-28 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 15:05 [PATCH] IPVS: ip_vs_pe.c, use strncmp to be safe Hans Schillstrom
2010-10-28 7:56 ` Simon Horman
2010-10-28 10:33 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC95177.1060008@trash.net \
--to=kaber@trash.net \
--cc=hans.schillstrom@ericsson.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.