Re: [PATCH] nfs-utils: fix default value for --enable-tirpc

[Steve Dickson <SteveD@redhat.com>]

Jeff,

On 10/11/2010 09:29 PM, Jeff Layton wrote:
> The patch I originally proposed to make --enable-tirpc the default had
> the default for $enable_tirpc as a blank string. When it was merged
> however, that value was changed to a 'yes'. 
Which commit or proposal are you talking about? I'm looking at commit 148503a
which changed it for no to yes, but I can not seem to find the 
proposal you are talking about?

I'm just trying to figure how the merge broke it so it does
not happen again... 

steved.

> This broke the ability for
> autoconf to detect and autodisable building with tirpc. When tirpc isn't
> present now, the configure step fails unless someone explicitly
> specifies --disable-libtirpc.
> 
> We need $enable_tirpc to be a tristate. 'yes' means that someone
> explicitly requested building with tirpc. 'no' means that it was
> explicitly disabled. Anything else means that no one specified a value.
> 
> Fix it by setting the value to a blank string so that the default is
> properly undefined.
> 
> Reported-by: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 3058be6..5408e85 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
>  	[AC_HELP_STRING([--enable-tirpc],
>  			[enable use of TI-RPC @<:@default=yes@:>@])],
>  	enable_tirpc=$enableval,
> -	enable_tirpc='yes')
> +	enable_tirpc='')
>  AC_ARG_ENABLE(ipv6,
>  	[AC_HELP_STRING([--enable-ipv6],
>                          [enable support for IPv6 @<:@default=no@:>@])],