From: Arnd Hannemann <arnd@arndnet.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: b43 sdio: WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd
Date: Thu, 28 Oct 2010 17:08:54 +0200 [thread overview]
Message-ID: <4CC99206.5090105@arndnet.de> (raw)
In-Reply-To: <4CC98D85.20703@lwfinger.net>
Hi,
Am 28.10.2010 16:49, schrieb Larry Finger:
> On 10/28/2010 09:28 AM, Arnd Hannemann wrote:
>> Hi,
> \> [ 1364.620044] b43-phy1 debug: Removing Interface type 2
>> [ 1364.621812] b43-phy1 debug: Wireless interface stopped
>> [ 1372.440297] b43-sdio: before ssb_bus_unregister, claimed is 0
>> [ 1372.440345] b43-sdio: before sdio_disable_func, claimed is 0
>> [ 1372.440351] ------------[ cut here ]------------
>> [ 1372.440367] WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd+0x88/0x90()
>
> Please try the patch below. It claims the device before the sdio_disable_func(()
> call and releases it afterwords.
>
> Index: wireless-testing/drivers/net/wireless/b43/sdio.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/sdio.c
> +++ wireless-testing/drivers/net/wireless/b43/sdio.c
> @@ -175,7 +175,9 @@ static void b43_sdio_remove(struct sdio_
> struct b43_sdio *sdio = sdio_get_drvdata(func);
>
> ssb_bus_unregister(&sdio->ssb);
> + sdio_claim_host(func);
> sdio_disable_func(func);
> + sdio_release_host(func);
> kfree(sdio);
> sdio_set_drvdata(func, NULL);
> }
>
Thanks, that fixes the warning.
Regards
Arnd
next prev parent reply other threads:[~2010-10-28 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 18:52 b43 sdio: WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd Arnd Hannemann
2010-10-27 18:52 ` Arnd Hannemann
[not found] ` <4CC874F4.5050908-BCMAnToX5e2ELgA04lAiVw@public.gmane.org>
2010-10-28 0:58 ` Larry Finger
2010-10-28 0:58 ` Larry Finger
[not found] ` <4CC8CAAE.3040100-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2010-10-28 14:28 ` Arnd Hannemann
2010-10-28 14:28 ` Arnd Hannemann
2010-10-28 14:49 ` Larry Finger
2010-10-28 15:08 ` Arnd Hannemann [this message]
[not found] ` <4CC99206.5090105-BCMAnToX5e2ELgA04lAiVw@public.gmane.org>
2010-10-28 15:11 ` Michael Büsch
2010-10-28 15:11 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC99206.5090105@arndnet.de \
--to=arnd@arndnet.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.