From: Bryan Schumaker <bjschuma@netapp.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs-utils: add nfs.idmap
Date: Thu, 28 Oct 2010 11:27:39 -0400 [thread overview]
Message-ID: <4CC9966B.1050103@netapp.com> (raw)
In-Reply-To: <4CC99463.9000108@RedHat.com>
On 10/28/2010 11:18 AM, Steve Dickson wrote:
> Hey Bryan,
>
> A couple nits.... which I will be more than willing to take of...
>
> 1) I would like to change the binary name from nfs.idmap to nfsidmap
> which is consistent with how the rest of the binaries are named.
> (i.e. binary names generally don't have any '.' or '-' in them)
>
> 2) Change the source directory from utils/nfs.idmap to
> utils/idmap which again makes it consistent with what
> is already there.
These both sounds reasonable to me. I'll make a patch to modify the kernel documentation to reflect this.
>
> 3) The man page talks about a /usr/sbin/idmap file and then
> later talks about a /usr/sbin/nfs.idmap program. Can I
> assume those are same binary, since I only see on binary
> being installed? Also, maybe we should move the binary to
> /sbin so it would be available early in the boot
>
> Comments?
Yes, those are the same binary. I don't know how that slipped through, but thanks for catching it. Making it available early in the boot sounds like it could be useful. I'll change this in the kernel documentation, too.
>
> steved.
next prev parent reply other threads:[~2010-10-28 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 12:48 [PATCH] nfs-utils: add nfs.idmap Bryan Schumaker
2010-10-26 17:17 ` Bryan Schumaker
2010-10-28 15:18 ` Steve Dickson
2010-10-28 15:27 ` Bryan Schumaker [this message]
2010-10-28 15:40 ` Trond Myklebust
2010-10-28 15:45 ` Steve Dickson
2010-10-28 15:51 ` Trond Myklebust
2010-10-28 16:04 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9966B.1050103@netapp.com \
--to=bjschuma@netapp.com \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.