All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: "lkml, " <linux-kernel@vger.kernel.org>
Subject: Getting started with the Linux kernel vDSO
Date: Thu, 28 Oct 2010 10:03:05 -0700	[thread overview]
Message-ID: <4CC9ACC9.1060207@linux.intel.com> (raw)

I'm trying to figure out how to go about adding a function to the Linux
vDSO. What I'm trying to accomplish is pretty basic: add a function to
the vDSO that can read from a chunk of user-readable kernel memory and
return a boolean.

long tidrunning(pid_t tid);

This is for a mostly userspace version follow-on to this as a POC for
Plumbers: http://lwn.net/Articles/386536/

To start, I'm just trying to return a static value and I'll get to
mapping in the memory block later. I mimicked the x86/vdso/vgetcpu.c to
create vtidrunning.c, updated the Makefile, and built the kernel,
resulting in a vdso.so that now has the desired symbols:

$ objdump -T arch/x86/vdso/vdso.so

arch/x86/vdso/vdso.so:     file format elf64-x86-64

DYNAMIC SYMBOL TABLE:
ffffffffff70035c l    d  .eh_frame_hdr	0000000000000000              .eh_frame_hdr
ffffffffff7008d0  w   DF .text	000000000000009c  LINUX_2.6   clock_gettime
0000000000000000 g    DO *ABS*	0000000000000000  LINUX_2.6   LINUX_2.6
ffffffffff700790 g    DF .text	000000000000008a  LINUX_2.6   __vdso_gettimeofday
ffffffffff7009b0 g    DF .text	0000000000000008  LINUX_2.6   __vdso_tidrunning
ffffffffff7009b0  w   DF .text	0000000000000008  LINUX_2.6   tidrunning
ffffffffff700970 g    DF .text	000000000000003d  LINUX_2.6   __vdso_getcpu
ffffffffff700790  w   DF .text	000000000000008a  LINUX_2.6   gettimeofday
ffffffffff700970  w   DF .text	000000000000003d  LINUX_2.6   getcpu
ffffffffff7008d0 g    DF .text	000000000000009c  LINUX_2.6   __vdso_clock_gettime

Note the two new symbols: tidrunning and __vdso_tidrunning.

I'm having trouble linking to them. glibc takes the vsyscall approach
and just calls a calculated address directly for getcpu (on x86_64
anyway). It does use the vdso version of gettimeofday for powerpc and
x86_64, but the amount of symbol lookup code is staggering. I was
hoping to find a way to link to this new symbol without having to
patch glibc (or untangle the symbol lookup code for use in a
stand-alone testcase).

Unfortunately, adding the vdso.so path to ld.so.conf.d/... doesn't
pickup vdso.so on the next run of ldconfig, and the link step of the
compile obviously fails to find the library. My test app is simple:

#include <stdio.h>
#include <sys/types.h>

extern long tidrunning(pid_t *tid);

int main(int argc, char *argv[])
{
	long running = tidrunning(0);
	printf("tid 0 is %s\n", running ? "running" : "not running");
	return 0;
}

Am I veering off into the weeds here? What is the proper way to link
to the vdso? My current kernel patch (just a hack still) follows:


diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index 4a2afa1..09c10c9 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -11,7 +11,7 @@ vdso-install-$(VDSO32-y)	+= $(vdso32-images)
   # files to link into the vdso
-vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o vvar.o
+vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o vvar.o vtidrunning.o
  # files to link into kernel
 obj-$(VDSO64-y)			+= vma.o vdso.o
diff --git a/arch/x86/vdso/vdso.lds.S b/arch/x86/vdso/vdso.lds.S
index 4e5dd3b..21255eb 100644
--- a/arch/x86/vdso/vdso.lds.S
+++ b/arch/x86/vdso/vdso.lds.S
@@ -23,6 +23,8 @@ VERSION {
 		__vdso_gettimeofday;
 		getcpu;
 		__vdso_getcpu;
+		tidrunning;
+		__vdso_tidrunning;
 	local: *;
 	};
 }
diff --git a/arch/x86/vdso/vtidrunning.c b/arch/x86/vdso/vtidrunning.c
new file mode 100644
index 0000000..642c25c
--- /dev/null
+++ b/arch/x86/vdso/vtidrunning.c
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2010 Darren Hart, Intel Corporation
+ * Subject to the GNU Public License, v.2
+ *
+ * User context test for tid running state.
+ */
+
+#include <linux/kernel.h>
+#include <linux/getcpu.h>
+#include <linux/jiffies.h>
+#include <linux/time.h>
+#include <asm/vsyscall.h>
+#include <asm/vgtod.h>
+#include "vextern.h"
+
+notrace long
+__vdso_tidrunning(pid_t *tid)
+{
+	return 0;
+}
+
+long tidrunning(pid_t *tid)
+	__attribute__((weak, alias("__vdso_tidrunning")));

-- 
Darren Hart
Embedded Linux Kernel

                 reply	other threads:[~2010-10-28 17:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC9ACC9.1060207@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.