From: Randy Dunlap <randy.dunlap@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <greg@kroah.com>,
Charles Manning <manningc2@actrix.gen.nz>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: How do I add yaffs file system to mainline?
Date: Thu, 28 Oct 2010 11:31:13 -0700 [thread overview]
Message-ID: <4CC9C171.80705@oracle.com> (raw)
In-Reply-To: <1288290559.1836.23.camel@Joe-Laptop>
On 10/28/10 11:29, Joe Perches wrote:
> On Thu, 2010-10-28 at 11:08 -0700, Greg KH wrote:
>> On Fri, Oct 29, 2010 at 06:55:39AM +1300, Charles Manning wrote:
>>> I know there is a style guide etc, but when we're talking about processing 15k
>>> loc then some of those rules might be slightly bendable.
>>
>> Not really.
>>
>> Have you run it through sparse and scripts/checkpatch.pl? If not,
>> please do so and resolve all of the issues that they bring up.
>
> I wouldn't do that. Checkpatch is useful but frequently wrong.
> By all means do use checkpatch, but please use your own taste to
> determine what you think needs fixing.
Absolutely.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-10-28 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 15:55 How do I add yaffs file system to mainline? Charles Manning
2010-10-28 17:26 ` Randy Dunlap
2010-10-28 17:41 ` Charles Manning
2010-10-28 17:49 ` Greg KH
2010-10-28 18:15 ` David Daney
2010-10-28 18:23 ` Greg KH
2010-10-28 17:44 ` Greg KH
2010-10-28 17:55 ` Charles Manning
2010-10-28 18:08 ` Greg KH
2010-10-28 18:29 ` Joe Perches
2010-10-28 18:31 ` Randy Dunlap [this message]
2010-10-28 18:38 ` Charles Manning
2010-10-28 18:40 ` Randy Dunlap
2010-10-29 19:16 ` James Cloos
-- strict thread matches above, loose matches on Subject: below --
2010-10-28 0:08 Charles Manning
2010-10-28 17:58 ` Corey Ashford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9C171.80705@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manningc2@actrix.gen.nz \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.