All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: "Cihula, Joseph" <joseph.cihula@intel.com>
Cc: "Wang, Shane" <shane.wang@intel.com>,
	Xen-devel <xen-devel@lists.xensource.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: c/s 21886 change to DMAR table hiding
Date: Fri, 29 Oct 2010 08:54:27 +0200	[thread overview]
Message-ID: <4CCA6FA3.4090607@ts.fujitsu.com> (raw)
In-Reply-To: <4F65016F6CB04E49BFFA15D4F7B798D9014EE2CB2D@orsmsx506.amr.corp.intel.com>

On 10/29/10 08:06, Cihula, Joseph wrote:
> Keir,
>
> In c/s 21886, you changed the method by which the DMAR ACPI table was hidden from dom0.  Why was this change needed?
> -    dmar->header.signature[0] = '\0';
> +    dmar->header.signature[0] = 'X';
> +    dmar->header.checksum -= 'X'-'D';
>
> I ask because tboot was using the original method to unhide/re-hide the table during S3 (because the TXT launch on S3 resume requires a valid DMAR table) and this has broken S3 w/ TXT.

Please see discussion under
http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01517.html

Problem was crash kernel not comig up with the original DMAR hide.


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

      reply	other threads:[~2010-10-29  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29  6:06 c/s 21886 change to DMAR table hiding Cihula, Joseph
2010-10-29  6:54 ` Juergen Gross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CCA6FA3.4090607@ts.fujitsu.com \
    --to=juergen.gross@ts.fujitsu.com \
    --cc=allen.m.kay@intel.com \
    --cc=joseph.cihula@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=shane.wang@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.