From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH] xen: events: do not unmask polled ipis on restore.
Date: Fri, 29 Oct 2010 10:42:33 -0700 [thread overview]
Message-ID: <4CCB0789.4040203@goop.org> (raw)
In-Reply-To: <1288373709.8069.23.camel@localhost.localdomain>
On 10/29/2010 10:35 AM, Ian Campbell wrote:
> On Fri, 2010-10-29 at 17:44 +0100, Jeremy Fitzhardinge wrote:
>> On 10/29/2010 01:33 AM, Ian Campbell wrote:
>>> The Xen PV spinlock backend attempts to setup an IPI to IRQ binding
>>> which is only to be used via xen_poll_irq rather received directly.
>>>
>>> Unfortunately restore_cpu_ipis unconditionally unmasks each IPI
>>> leading to:
>> Gosh I wonder why we hadn't seen this before?
> I must admit I don't normally enable CONFIG_PARAVIRT_SPINLOCKS I
> happened to be running someone else's config when I noticed this.
>
> Possibly relates to switching to the edge triggered handler and the
> related mask/unmask vs clear etc frobbing?
Possibly. Did you see my comment further down?
J
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
next prev parent reply other threads:[~2010-10-29 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 8:33 [PATCH] xen: events: do not unmask polled ipis on restore Ian Campbell
2010-10-29 16:44 ` Jeremy Fitzhardinge
2010-10-29 17:35 ` Ian Campbell
2010-10-29 17:42 ` Jeremy Fitzhardinge [this message]
2010-10-29 17:45 ` Ian Campbell
2010-10-29 17:52 ` Ian Campbell
2010-11-01 14:51 ` Ian Campbell
2010-11-01 16:31 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCB0789.4040203@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.