From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: orion5x/kirkwood/mv78xx0: fix MPP configuration corner cases
Date: Sat, 30 Oct 2010 23:18:52 +0100 [thread overview]
Message-ID: <4CCC99CC.6050808@fluff.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1010290007070.6603@xanadu.home>
On 29/10/10 05:12, Nicolas Pitre wrote:
> On Sun, 24 Oct 2010, Mike Rapoport wrote:
>
>> Wrong MPP configuration would cause <cpu>_mpp_conf loop infinitely
>> because the mpp list iterator would not be incremented.
>>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---
>> arch/arm/mach-kirkwood/mpp.c | 5 +++--
>> arch/arm/mach-mv78xx0/mpp.c | 5 +++--
>> arch/arm/mach-orion5x/mpp.c | 5 +++--
>> 3 files changed, 9 insertions(+), 6 deletions(-)
> [...]
>
> Instead of adding gotos, could you simply replace the
> "while (*mpp_list)" loop with "for ( ; *mpp_list; mpp_list++)" ?
you'd have to remove the mpp_list++, but this would be in my
view a nicer solution avoiding gotos and any re-occurence of
this in the future.
--
Ben
prev parent reply other threads:[~2010-10-30 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 8:12 [PATCH] ARM: orion5x/kirkwood/mv78xx0: fix MPP configuration corner cases Mike Rapoport
2010-10-28 13:13 ` Mike Rapoport
2010-10-29 4:12 ` Nicolas Pitre
2010-10-30 22:18 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCC99CC.6050808@fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.