From mboxrd@z Thu Jan  1 00:00:00 1970
From: DDD <dongdong.deng@windriver.com>
Subject: Re: [PATCH] drm/i915/sdvo: Fix harmless build warning
Date: Mon, 01 Nov 2010 10:39:45 +0800
Message-ID: <4CCE2871.1010103@windriver.com>
References: <1288348298-28192-1-git-send-email-dongdong.deng@windriver.com>
	<20101030113029.23012.qmail@stuge.se>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
	by gabe.freedesktop.org (Postfix) with ESMTP id E69589E74B
	for <dri-devel@lists.freedesktop.org>;
	Sun, 31 Oct 2010 19:33:03 -0700 (PDT)
In-Reply-To: <20101030113029.23012.qmail@stuge.se>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: peter@stuge.se
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Peter Stuge wrote:
> Dongdong Deng wrote:
>> Removing the following harmless build warning to let compiler happy.
> 
>> @@ -1170,7 +1170,8 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder,
>>  	switch (sdvo_pixel_multiply) {
>>  	case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
>>  	case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
>> -	case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
>> +	case 4:
>> +	default: rate = SDVO_CLOCK_RATE_MULT_4X;
>>  	}
>>  	if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
>>  		return;
> 
> Even if the default case can not trigger, is 4x a good default multiplier?
> 
> Also, shouldn't there be a break; also in the default: case?

Hello Peter,

In the last maintree, the warning have gone with following changing. :-)

     switch (pixel_multiplier) {
     default:
     case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
     case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
     case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
     }


Thanks,
Dongdong

> 
> 
> //Peter
>