From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Use dynamic allocation for buffer when reporting tags
Date: Mon, 01 Nov 2010 14:16:25 +0100 [thread overview]
Message-ID: <4CCEBDA9.1060107@redhat.com> (raw)
In-Reply-To: <4CCEBBBB.2050705@redhat.com>
On 11/01/2010 02:08 PM, Peter Rajnoha wrote:
> OK, here's updated version (based on quick hints from Milan).
ack + tested, works for my test script
> @@ -902,11 +919,13 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field)
>
> if (!dm_pool_grow_object(rh->mem, rh->output_field_name_prefix, 0)) {
> log_error("dm_report: Unable to extend output line");
> + free(field_id);
> return 0;
just mention in changelog that this is additional memleak fix.
Milan
next prev parent reply other threads:[~2010-11-01 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 12:04 [PATCH] Use dynamic allocation for buffer when reporting tags Peter Rajnoha
2010-11-01 13:08 ` Peter Rajnoha
2010-11-01 13:16 ` Milan Broz [this message]
2010-11-01 13:21 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCEBDA9.1060107@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.