From: Jeff Garzik <jeff@garzik.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Boaz Harrosh <bharrosh@panasas.com>,
James.Bottomley@suse.de, nab@linux-iscsi.org,
linux-scsi@vger.kernel.org
Subject: Re: Full hostlock pushdown available
Date: Mon, 01 Nov 2010 11:56:47 -0400 [thread overview]
Message-ID: <4CCEE33F.5030300@garzik.org> (raw)
In-Reply-To: <20101101135338.GA25817@basil.fritz.box>
On 11/01/2010 09:53 AM, Andi Kleen wrote:
>> > Missing drivers/ata/libata-scsi.c modification?
> Ah thanks for noticing. I missed that because it defined queuecommand
> in a header plus a macro. Fixed in the tree. I also did another grep to make
> sure there a no other occurrences. And fixed some documentation.
>
> Updated tree
You have just recreated the same bug Nicholas did: you incorrectly
removed the required _irqsave and _irqrestore from ap->lock.
Please check your changes closely to make sure you haven't duplicated
this bug in other drivers.
This is _precisely_ why I like Boaz' suggestion: it better guarantees
the locking remains unchanged. Apparently your change, like Nicholas's,
is not so mechanical after all.
Jeff
next prev parent reply other threads:[~2010-11-01 15:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 15:05 Full hostlock pushdown available Andi Kleen
2010-10-28 19:28 ` James Bottomley
2010-10-28 19:32 ` Nicholas A. Bellinger
2010-11-01 14:06 ` Andi Kleen
2010-11-01 14:29 ` James Bottomley
2010-10-28 20:10 ` Andi Kleen
2010-10-28 20:22 ` James Bottomley
2010-10-28 21:50 ` Andi Kleen
2010-10-28 22:37 ` Nicholas A. Bellinger
2010-10-31 12:22 ` Boaz Harrosh
2010-10-31 18:48 ` Stefan Richter
2010-11-01 2:34 ` Jeff Garzik
2010-11-01 13:53 ` Andi Kleen
2010-11-01 15:56 ` Jeff Garzik [this message]
2010-11-01 17:57 ` Andi Kleen
2010-11-01 18:42 ` Jeff Garzik
2010-11-02 15:05 ` Andi Kleen
2010-11-01 18:59 ` Jeff Garzik
2010-11-01 21:06 ` Nicholas A. Bellinger
2010-11-02 9:21 ` Andi Kleen
2010-11-02 15:59 ` Jeff Garzik
2010-11-02 17:53 ` Andi Kleen
2010-11-02 18:13 ` Jeff Garzik
2010-11-02 18:38 ` Nicholas A. Bellinger
2010-11-02 18:50 ` Jeff Garzik
2010-11-01 13:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCEE33F.5030300@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@suse.de \
--cc=andi@firstfloor.org \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.