From: Saul Wold <saul.wold@intel.com>
To: poky@pokylinux.org
Subject: Re: [PULL]Fix adding GDBM_File module for perl
Date: Mon, 01 Nov 2010 18:19:33 +0000 [thread overview]
Message-ID: <4CCF04B5.4030606@intel.com> (raw)
In-Reply-To: <4CCE94E0.50903@windriver.com>
On 11/01/2010 10:22 AM, Lu Jingdong wrote:
> Note:<commit_id> parameter assumed as 'HEAD'
>
> meta/recipes-devtools/perl/perl-5.8.8/config.sh | 8
> meta/recipes-devtools/perl/perl-5.8.8/perl-enable-gdbm.patch | 17 +
> meta/recipes-devtools/perl/perl_5.8.8.bb | 2
>
This patch looks OK to me and I will pull it.
(Nitin, please take note of this config change for your work).
> meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.12-zlib.patch | 169 ++++++++++
> meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-data_types.patch | 32 +
> meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-help-index-segfault.patch | 23 +
> meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-mosdo-crash.patch | 11
> meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-powerpc.patch | 12
> meta/recipes-extended/texinfo/texinfo_4.13a.bb | 57 +++
I am just reviewing the textinfo patch at this point and first comment
is that you need to comment the patches, there is no information about
their origin and why they are needed.
As we are adding a new recipe, is this based on the existing
OpenEmbedded recipe and if so, you need to credit OE. I noticed in OE
that they have a different set of depends and patches, so I wanted to
verify this.
Minor nit: for SRC_URI, you could use ${PN} as follows:
http://ftp.gnu.org/gnu/${PN}/${PN}-${PV}.tar.gz
Sau!
> 9 files changed, 327 insertions(+), 4 deletions(-)
>
> Jingdong Lu (2):
> texinfo: Add new package
> Fix adding GDBM_File module for LSB test.
>
> Pull URL:
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro
>
next prev parent reply other threads:[~2010-11-01 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 10:22 [PULL]Fix adding GDBM_File module for perl Lu Jingdong
2010-11-01 18:19 ` Saul Wold [this message]
2010-11-01 19:32 ` Mark Hatle
2010-11-05 13:34 ` Richard Purdie
2010-11-05 16:14 ` Mark Hatle
2010-11-22 18:14 ` Saul Wold
2010-11-24 5:05 ` Lu Jingdong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCF04B5.4030606@intel.com \
--to=saul.wold@intel.com \
--cc=poky@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.