From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45796 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PCzLC-0006UA-Cb
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:42:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PCzLB-0005Gd-8O
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:42:46 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:63172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PCzLA-0005GW-TH
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:42:45 -0400
Message-ID: <4CCF0A13.1060202@mail.berlios.de>
Date: Mon, 01 Nov 2010 19:42:27 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation
References: <1288623713-28062-1-git-send-email-agraf@suse.de>	<1288623713-28062-3-git-send-email-agraf@suse.de>
	<AANLkTiksFJ78Tid9MLHNyvxbKe4K3eBjgUf=1Lt8UkOK@mail.gmail.com>
In-Reply-To: <AANLkTiksFJ78Tid9MLHNyvxbKe4K3eBjgUf=1Lt8UkOK@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Alexander Graf <agraf@suse.de>, qemu-devel Developers <qemu-devel@nongnu.org>

Am 01.11.2010 19:29, schrieb Blue Swirl:
> On Mon, Nov 1, 2010 at 3:01 PM, Alexander Graf<agraf@suse.de>  wrote:
>    
>> ---
>>   hw/elf_ops.h |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   hw/loader.c  |    7 ++++++
>>   hw/loader.h  |    3 ++
>>   3 files changed, 70 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/elf_ops.h b/hw/elf_ops.h
>> index 8b63dfc..645d058 100644
>> --- a/hw/elf_ops.h
>> +++ b/hw/elf_ops.h
>> @@ -189,6 +189,44 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehdr, int fd, int must_swab,
>>      return -1;
>>   }
>>
>> +static void glue(elf_read_notes, SZ)(uint8_t *data, int data_len,
>> +                                     ElfHandlers *handlers, int must_swab)
>> +{
>> +    uint8_t *p = data;
>> +
>> +    while ((ulong)&p[3]<  (ulong)&data[data_len]) {
>>      
> Please use 'unsigned long'.
>    

Why is a type cast used here? I see no reason for it.