From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45582 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PD0qp-0003qB-H6
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 16:19:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PD0qo-0004Ip-B2
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 16:19:31 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:62651)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PD0qn-0004IF-W5
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 16:19:30 -0400
Message-ID: <4CCF20BE.8010205@mail.berlios.de>
Date: Mon, 01 Nov 2010 21:19:10 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation
References: <1288623713-28062-1-git-send-email-agraf@suse.de>	<1288623713-28062-3-git-send-email-agraf@suse.de>
	<AANLkTiksFJ78Tid9MLHNyvxbKe4K3eBjgUf=1Lt8UkOK@mail.gmail.com>
	<4CCF0A13.1060202@mail.berlios.de>
	<E2FC622E-64DE-48E9-99A2-47CA09D5298E@suse.de>
In-Reply-To: <E2FC622E-64DE-48E9-99A2-47CA09D5298E@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Am 01.11.2010 20:51, schrieb Alexander Graf:
> On 01.11.2010, at 14:42, Stefan Weil wrote:
>
>    
>> Am 01.11.2010 19:29, schrieb Blue Swirl:
>>      
>>> On Mon, Nov 1, 2010 at 3:01 PM, Alexander Graf<agraf@suse.de>   wrote:
>>>
>>>        
>>>> ---
>>>>   hw/elf_ops.h |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>>   hw/loader.c  |    7 ++++++
>>>>   hw/loader.h  |    3 ++
>>>>   3 files changed, 70 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/hw/elf_ops.h b/hw/elf_ops.h
>>>> index 8b63dfc..645d058 100644
>>>> --- a/hw/elf_ops.h
>>>> +++ b/hw/elf_ops.h
>>>> @@ -189,6 +189,44 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehdr, int fd, int must_swab,
>>>>      return -1;
>>>>   }
>>>>
>>>> +static void glue(elf_read_notes, SZ)(uint8_t *data, int data_len,
>>>> +                                     ElfHandlers *handlers, int must_swab)
>>>> +{
>>>> +    uint8_t *p = data;
>>>> +
>>>> +    while ((ulong)&p[3]<   (ulong)&data[data_len]) {
>>>>
>>>>          
>>> Please use 'unsigned long'.
>>>
>>>        
>> Why is a type cast used here? I see no reason for it.
>>      
> Pointers can't be compared, you have to cast them to values first.
>
>
> Alex
>    

No. Pointers of same type which are not void pointers can be compared.

There is even a data type ptrdiff_t, so you can also compare their
difference with zero.

Regards,
Stefan