From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCHv2] trace "exit to userspace" event
Date: Mon, 01 Nov 2010 17:19:40 -0400 [thread overview]
Message-ID: <4CCF2EEC.2010901@redhat.com> (raw)
In-Reply-To: <20101101194356.GA8645@amt.cnet>
On 11/01/2010 03:43 PM, Marcelo Tosatti wrote:
> On Mon, Nov 01, 2010 at 03:33:20PM -0400, Avi Kivity wrote:
> > On 11/01/2010 12:06 PM, Marcelo Tosatti wrote:
> > >On Sun, Oct 24, 2010 at 04:49:08PM +0200, Gleb Natapov wrote:
> > >> Add tracepoint for userspace exit.
> > >>
> > >> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> > >> ---
> > >> ChangeLog:
> > >> v1->v2
> > >> log error case too.
> > >
> > >Applied, thanks.
> > >
> >
> > errno sign is still flipped, no?
>
> No, kvm_arch_vcpu_ioctl_run return -errno on error.
>
It's true that this is how the kernel ABI is defined, but for a user
errnos are positive.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-11-01 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 14:49 [PATCHv2] trace "exit to userspace" event Gleb Natapov
2010-10-24 17:01 ` Avi Kivity
2010-10-24 17:24 ` Gleb Natapov
2010-10-24 17:27 ` Avi Kivity
2010-10-24 17:37 ` Gleb Natapov
2010-11-01 16:06 ` Marcelo Tosatti
2010-11-01 19:33 ` Avi Kivity
2010-11-01 19:43 ` Marcelo Tosatti
2010-11-01 21:19 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCF2EEC.2010901@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.