From: Thomas Hellstrom <thomas@shipmail.org>
To: Matt Turner <mattst88@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments
Date: Mon, 01 Nov 2010 23:00:03 +0100 [thread overview]
Message-ID: <4CCF3863.9040500@shipmail.org> (raw)
In-Reply-To: <AANLkTinYZ=ZpkRiL2eMtcO_fAAFhBBCoT2fLH0tKaNn9@mail.gmail.com>
On 11/01/2010 12:52 AM, Matt Turner wrote:
> On Sun, Oct 31, 2010 at 6:33 PM, Joe Perches<joe@perches.com> wrote:
>
>> Signed-off-by: Joe Perches<joe@perches.com>
>> ---
>> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> index a01c47d..29113c9 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> @@ -557,7 +557,7 @@ int vmw_kms_init_legacy_display_system(struct vmw_private *dev_priv)
>> return -EINVAL;
>> }
>>
>> - dev_priv->ldu_priv = kmalloc(GFP_KERNEL, sizeof(*dev_priv->ldu_priv));
>> + dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
>>
>> if (!dev_priv->ldu_priv)
>> return -ENOMEM;
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> index df2036e..f1a52f9 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> @@ -585,7 +585,7 @@ int vmw_overlay_init(struct vmw_private *dev_priv)
>> return -ENOSYS;
>> }
>>
>> - overlay = kmalloc(GFP_KERNEL, sizeof(*overlay));
>> + overlay = kmalloc(sizeof(*overlay), GFP_KERNEL);
>> if (!overlay)
>> return -ENOMEM;
>>
>> --
>> 1.7.3.1.g432b3.dirty
>>
> Oh! That's a bad one.
>
Indeed.
> Reviewed-by: Matt Turner<mattst88@gmail.com>
>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
next prev parent reply other threads:[~2010-11-01 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 22:33 [PATCH 0/4] Fix k.alloc switched arguments Joe Perches
2010-10-31 22:33 ` Joe Perches
2010-10-31 22:33 ` [PATCH 1/4] drivers/gpu/drm/vmwgfx: " Joe Perches
2010-10-31 23:52 ` Matt Turner
2010-11-01 22:00 ` Thomas Hellstrom [this message]
2010-10-31 22:33 ` [PATCH 2/4] drivers/scsi/pmcraid.c: " Joe Perches
2010-10-31 22:33 ` [PATCH 3/4] drivers/staging/udlfb/udlfb.c: " Joe Perches
2010-10-31 22:33 ` [PATCH 4/4] scripts/checkpatch.pl: Add check for k.alloc GFP as first argument Joe Perches
2010-11-01 21:57 ` Jesper Juhl
2010-11-02 22:47 ` [RESEND PATCH 2/4] drivers/scsi/pmcraid.c: Fix k.alloc switched arguments Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCF3863.9040500@shipmail.org \
--to=thomas@shipmail.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.