All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksey Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>,
	Alex Rosenbaum <Alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: [PATCH V2 2/3] Security check on QP type
Date: Wed, 03 Nov 2010 16:35:49 +0200	[thread overview]
Message-ID: <4CD17345.7040400@voltaire.com> (raw)
In-Reply-To: <4CD172C8.4010700-smomgflXvOZWk0Htik3J/w@public.gmane.org>

Check if user process has permission to create RAW_PACKET QP.

In order to prevent regular user from creating malicious packets, at the
time of QP creation, kernel will check if the process has necessary
permissions. This examination areis done in uverbs layer and is general
for all low level drivers.

Signed-off-by: Aleksey Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/core/uverbs_cmd.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 6fcfbeb..87025fc 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1050,6 +1050,9 @@ ssize_t ib_uverbs_create_qp(struct ib_uverbs_file *file,
 	if (copy_from_user(&cmd, buf, sizeof cmd))
 		return -EFAULT;
 
+	if (cmd.qp_type == IB_QPT_RAW_PACKET && !capable(CAP_NET_RAW))
+		return -EPERM;
+
 	INIT_UDATA(&udata, buf + sizeof cmd,
 		   (unsigned long) cmd.response + sizeof resp,
 		   in_len - sizeof cmd, out_len - sizeof resp);
-- 
1.6.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-11-03 14:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 14:30 [PATCH V2 0/3] New RAW_PACKET QP type Aleksey Senin
     [not found] ` <4CD171F0.8020506-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-11-03 14:33   ` [PATCH V2 1/3] RAW_PACKET QP type definition Aleksey Senin
     [not found]     ` <4CD172C8.4010700-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-11-03 14:35       ` Aleksey Senin [this message]
     [not found]         ` <4CD17345.7040400-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-11-03 14:37           ` [PATCH V2 3/3] Add RAW_PACKET to ib_attach/detach mcast calls Aleksey Senin
2010-11-03 14:58   ` [PATCH V2 0/3] New RAW_PACKET QP type Hefty, Sean
     [not found]     ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B8308783-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-05 15:06       ` Steve Wise
     [not found]         ` <4CD41D5D.9030103-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-11-05 15:15           ` Hefty, Sean
     [not found]             ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B83D606E-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-05 15:20               ` Steve Wise
     [not found]                 ` <4CD420C3.1090803-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-11-05 16:05                   ` Hefty, Sean
     [not found]                     ` <CF9C39F99A89134C9CF9C4CCB68B8DDF25B83D6128-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-05 16:09                       ` Steve Wise
     [not found]                         ` <4CD42C54.7010609-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-11-07  6:50                           ` Or Gerlitz
     [not found]                             ` <4CD64C1D.6010908-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-11-07 21:04                               ` Steve Wise
2010-11-08  6:38           ` Alekseys Senin
2010-11-07 12:16       ` Alekseys Senin
2010-11-04 14:25   ` Or Gerlitz
2010-11-05 15:05   ` Steve Wise
2010-11-11 16:01   ` Alekseys Senin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD17345.7040400@voltaire.com \
    --to=alekseys-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=Alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org \
    --cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.