All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Fold send_all() wrapper unix_write() into one function
Date: Wed, 03 Nov 2010 13:27:58 -0500	[thread overview]
Message-ID: <4CD1A9AE.4050102@codemonkey.ws> (raw)
In-Reply-To: <1288638143-15227-1-git-send-email-Jes.Sorensen@redhat.com>

On 11/01/2010 02:02 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> The current send_all() wrapper for POSIX calls does nothing but call
> unix_write(). Merge them to simplify the code.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   qemu-char.c |    8 ++------
>   1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 6d2dce7..88997f9 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -508,9 +508,10 @@ int send_all(int fd, const void *buf, int len1)
>
>   #else
>
> -static int unix_write(int fd, const uint8_t *buf, int len1)
> +int send_all(int fd, const void *_buf, int len1)
>   {
>       int ret, len;
> +    const uint8_t *buf = _buf;
>
>       len = len1;
>       while (len>  0) {
> @@ -527,11 +528,6 @@ static int unix_write(int fd, const uint8_t *buf, int len1)
>       }
>       return len1 - len;
>   }
> -
> -int send_all(int fd, const void *buf, int len1)
> -{
> -    return unix_write(fd, buf, len1);
> -}
>   #endif /* !_WIN32 */
>
>   #ifndef _WIN32
>    

  reply	other threads:[~2010-11-03 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 19:02 [Qemu-devel] [PATCH 1/1] Fold send_all() wrapper unix_write() into one function Jes.Sorensen
2010-11-03 18:27 ` Anthony Liguori [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-10-15 14:41 Jes.Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD1A9AE.4050102@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Jes.Sorensen@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.