From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.pokylinux.org (Postfix) with ESMTP id 37DE94C80287 for ; Wed, 3 Nov 2010 17:34:41 -0500 (CDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 03 Nov 2010 15:34:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.58,291,1286175600"; d="scan'208";a="623303004" Received: from unknown (HELO [10.255.12.198]) ([10.255.12.198]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2010 15:34:40 -0700 Message-ID: <4CD1E380.8080207@intel.com> Date: Wed, 03 Nov 2010 15:34:40 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 MIME-Version: 1.0 To: Gary Thomas References: <4CD16A8E.7090100@mlbassoc.com> <4CD1815D.8050105@intel.com> <4CD1839D.7070606@mlbassoc.com> In-Reply-To: <4CD1839D.7070606@mlbassoc.com> Cc: Poky Subject: Re: Inconsistent timestamp use X-BeenThere: poky@pokylinux.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2010 22:34:41 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 11/03/2010 08:45 AM, Gary Thomas wrote: > On 11/03/2010 09:35 AM, Saul Wold wrote: >> On 11/03/2010 06:58 AM, Gary Thomas wrote: >>> The Poky root file system (init scripts) has a mechanism for >>> supporting systems without a working hardware [time of day] clock. >>> It seems that this has suffered some rot recently and is now >>> quite inconsistent: >>> * rootfs_update_timestamp() uses a different format for the time stamp >>> * the init scripts look for /etc/timestamp2, not /etc/timestamp which >>> is created with the image >>> >>> The attached patch makes this consistent and the system clock now works >>> much better (about as good as a machine without a hardware clock can!) >>> >> >> Hi Gary, >> >> This is a good change for the smaller images that use the busybox date >> function, but will break images that use the real date command. >> Unfortunately, they happen to use different formats for setting the time >> and date. >> >> It may be that we need 2 timestamp files, one for a busybox system and a >> second for the standard date command and then extend the check in the >> init scripts to figure out which date we are using currently. > > Fair enough. I was just trying to make what's there work consistently. > > Perhaps it's good enough to remove the "-s" option from the setting > function and change back to the old format (+%m%d%H%M%Y). I'm pretty > sure that the full-on date program will handle that, as does busybox. > I just verified that the +%2m%2d%2H%2M%Y format will work correctly for both version of dates, and you are correct that the -s option should go away. The save-rtc.sh script needs to be fixed to use the correct format. I reponed bug #265 and commented that, if you want to add yourself to that bug. Sau! > Note: I think the change 41d02d40ed83c791e7a4c1d57d829d706af42e74 was > actually incorrect. The proper change would have been to fix the > timestamp generation to be consistent. >