From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35938 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PE2VW-0002bN-5K
	for qemu-devel@nongnu.org; Thu, 04 Nov 2010 12:17:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1PE2VT-00027m-MC
	for qemu-devel@nongnu.org; Thu, 04 Nov 2010 12:17:46 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:53212)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1PE2VT-00027c-IN
	for qemu-devel@nongnu.org; Thu, 04 Nov 2010 12:17:43 -0400
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oA4G1k1Y003590
	for <qemu-devel@nongnu.org>; Thu, 4 Nov 2010 12:01:46 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	oA4GHbLK1458384
	for <qemu-devel@nongnu.org>; Thu, 4 Nov 2010 12:17:38 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	oA4GHbZj019872
	for <qemu-devel@nongnu.org>; Thu, 4 Nov 2010 12:17:37 -0400
Message-ID: <4CD2DCA0.1090503@linux.vnet.ibm.com>
Date: Thu, 04 Nov 2010 11:17:36 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1288798090-7127-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1288798090-7127-6-git-send-email-mdroth@linux.vnet.ibm.com>
	<1288825329.2846.29.camel@aglitke>
In-Reply-To: <1288825329.2846.29.camel@aglitke>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 05/15] virtproxy: add
 accept handler for communication channel
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: abeekhof@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com

On 11/03/2010 06:02 PM, Adam Litke wrote:
> On Wed, 2010-11-03 at 10:28 -0500, Michael Roth wrote:
>> This accept()'s connections to the socket we told virt-proxy to listen
>> for the channel connection on and sets the appropriate read handler for
>> the resulting FD.
>>
>> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
>> ---
>>   virtproxy.c |   37 +++++++++++++++++++++++++++++++++++++
>>   1 files changed, 37 insertions(+), 0 deletions(-)
>>
>> diff --git a/virtproxy.c b/virtproxy.c
>> index fa17722..20532c2 100644
>> --- a/virtproxy.c
>> +++ b/virtproxy.c
>> @@ -166,6 +166,8 @@ static VPConn *get_conn(const VPDriver *drv, int fd, bool client)
>>       return NULL;
>>   }
>>
>> +static void vp_channel_accept(void *opaque);
>> +
>
> Why the forward declaration?  Can you move the function to a different
> place in the file to avoid this?
>
>

For this particular one vp_channel_accept and vp_channel_read reference 
each other at least this one needed a forward declaration. I'll see what 
I can do about these...I'm hesitant to add yet another header file but 
if that's preferred way I can move all the declarations into a 
virtproxy-internal.h file as you suggested.