From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31453 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337Ab0KDTnk (ORCPT ); Thu, 4 Nov 2010 15:43:40 -0400 Message-ID: <4CD30CE5.5030003@redhat.com> Date: Thu, 04 Nov 2010 15:43:33 -0400 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: =?ISO-8859-1?Q?David_H=E4rdeman?= CC: Jarod Wilson , Jarod Wilson , linux-media@vger.kernel.org Subject: Re: [RFC PATCH 0/2] Apple remote support References: <20101029191711.GA12136@hardeman.nu> <20101029192733.GE21604@redhat.com> <20101029195918.GA12501@hardeman.nu> <20101029200937.GG21604@redhat.com> <20101030233617.GA13155@hardeman.nu> <20101101215635.GA4808@hardeman.nu> <37bb20b43afce52964a95a72a725b0e4@hardeman.nu> <20101104193823.GA9107@hardeman.nu> In-Reply-To: <20101104193823.GA9107@hardeman.nu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit List-ID: Sender: Mauro Carvalho Chehab Em 04-11-2010 15:38, David Härdeman escreveu: > On Thu, Nov 04, 2010 at 11:54:25AM -0400, Jarod Wilson wrote: >> Okay, so we seem to be in agreement for an approach to handling this. >> I'll toss something together implementing that RSN... Though I talked >> with Mauro about this a bit yesterday here at LPC, and we're thinking >> maybe we slide this support back over into the nec decoder and make it >> a slightly more generic "use full 32 bits" NEC variant we look for >> and/or enable/disable somehow. I've got another remote here, for a >> Motorola cable box, which is NEC-ish, but always fails decode w/a >> checksum error ("got 0x00000000", iirc), which may also need to use >> the full 32 bits somehow... Probably a very important protocol variant >> to support, particularly once we have native transmit support, as its >> used by plenty of cable boxes on the major carriers here in the US. > > I've always found the "checksum" tests in the NEC decoder to be unnecessary so I'm all for using a 32 bit scancode in all cases (and still using a module param to squash the ID byte of apple remotes, defaulting to "yes"). > This means changing all existing NEC tables to have 32 bits, and add the "redundant" information on all of them. It doesn't seem a good idea to me to add a penalty for those NEC tables that follow the standard. Mauro