From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hidetoshi Seto Subject: Re: [PATCH 1/5] PCI: MSI: Move MSI-X entry definition to pci_regs.h Date: Fri, 05 Nov 2010 09:43:38 +0900 Message-ID: <4CD3533A.7090908@jp.fujitsu.com> References: <1288851321-3964-1-git-send-email-sheng@linux.intel.com> <1288851321-3964-2-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "Michael S. Tsirkin" , kvm@vger.kernel.org, Jesse Barnes , linux-pci@vger.kernel.org To: Sheng Yang Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:57310 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650Ab0KEAoP (ORCPT ); Thu, 4 Nov 2010 20:44:15 -0400 In-Reply-To: <1288851321-3964-2-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yeah, I think there are many virtualization stuff awaiting this change in these days. Reviewed-by: Hidetoshi Seto (2010/11/04 15:15), Sheng Yang wrote: > Then it can be used by others. > > Reviewed-by: Matthew Wilcox > Cc: Jesse Barnes > Cc: linux-pci@vger.kernel.org > Signed-off-by: Sheng Yang > --- > drivers/pci/msi.h | 6 ------ > include/linux/pci_regs.h | 7 +++++++ > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/msi.h b/drivers/pci/msi.h > index de27c1c..28a3c52 100644 > --- a/drivers/pci/msi.h > +++ b/drivers/pci/msi.h > @@ -6,12 +6,6 @@ > #ifndef MSI_H > #define MSI_H > > -#define PCI_MSIX_ENTRY_SIZE 16 > -#define PCI_MSIX_ENTRY_LOWER_ADDR 0 > -#define PCI_MSIX_ENTRY_UPPER_ADDR 4 > -#define PCI_MSIX_ENTRY_DATA 8 > -#define PCI_MSIX_ENTRY_VECTOR_CTRL 12 > - > #define msi_control_reg(base) (base + PCI_MSI_FLAGS) > #define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO) > #define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI) > diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h > index 455b9cc..acfc224 100644 > --- a/include/linux/pci_regs.h > +++ b/include/linux/pci_regs.h > @@ -307,6 +307,13 @@ > #define PCI_MSIX_FLAGS_MASKALL (1 << 14) > #define PCI_MSIX_FLAGS_BIRMASK (7 << 0) > > +/* MSI-X entry's format */ > +#define PCI_MSIX_ENTRY_SIZE 16 > +#define PCI_MSIX_ENTRY_LOWER_ADDR 0 > +#define PCI_MSIX_ENTRY_UPPER_ADDR 4 > +#define PCI_MSIX_ENTRY_DATA 8 > +#define PCI_MSIX_ENTRY_VECTOR_CTRL 12 > + > /* CompactPCI Hotswap Register */ > > #define PCI_CHSWP_CSR 2 /* Control and Status Register */