All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: "Czarnowska, Anna" <anna.czarnowska@intel.com>
Cc: Neil Brown <neilb@suse.de>,
	"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>,
	"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
	"Labun, Marcin" <Marcin.Labun@intel.com>,
	"Hawrylewicz Czarnowski,
	Przemyslaw" <przemyslaw.hawrylewicz.czarnowski@intel.com>
Subject: Re: [PATCH 09/17] Monitor: avoid skipping checks on external arays
Date: Thu, 04 Nov 2010 22:47:11 -0700	[thread overview]
Message-ID: <4CD39A5F.2050703@intel.com> (raw)
In-Reply-To: <A9DE54D0CD747C4CB06DCE5B6FA2246F010BAF0FC9@irsmsx504.ger.corp.intel.com>

On 10/29/2010 7:23 AM, Czarnowska, Anna wrote:
>  From bb9ca6dbe0a92e00b21cd8985533b561b40ed6b9 Mon Sep 17 00:00:00 2001
> From: Anna Czarnowska<anna.czarnowska@intel.com>
> Date: Mon, 25 Oct 2010 11:30:43 +0200
> Subject: [PATCH 09/17] Monitor: avoid skipping checks on external arays
>
> utime is not correct for external metadata so we can only
> skip further checks for native metadata
>
> Signed-off-by: Anna Czarnowska<anna.czarnowska@intel.com>
> ---
>   Monitor.c |   33 ++++++++++++++++++++++++++-------
>   1 files changed, 26 insertions(+), 7 deletions(-)
>
> diff --git a/Monitor.c b/Monitor.c
> index a4bfedd..d915d7d 100644
> --- a/Monitor.c
> +++ b/Monitor.c
> @@ -50,6 +50,7 @@ struct state {
>   	int devstate[MaxDisks];
>   	unsigned devid[MaxDisks];
>   	int percent;
> +	char *metadata_version;

Another small nit... this is really just a "int utime_valid" flag, 
calling it "char *metadata_version" is a slightly confusing shortcut.

  reply	other threads:[~2010-11-05  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 14:23 [PATCH 09/17] Monitor: avoid skipping checks on external arays Czarnowska, Anna
2010-11-05  5:47 ` Dan Williams [this message]
2010-11-05 14:56   ` Czarnowska, Anna
2010-11-05 16:17     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD39A5F.2050703@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=Marcin.Labun@intel.com \
    --cc=Wojciech.Neubauer@intel.com \
    --cc=anna.czarnowska@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.