Re: [PATCH 4/4] power_supply: isp1704: Detect charger after probe

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 04-11-2010 17:31, Heikki Krogerus wrote:

> If the device is booted up with cable connected, or the
> module is loaded after plugging in the cable, the
> notification has come and gone, so not relying on it at
> probe time. Instead this checks the VBUS level manually
> after probe.

> Signed-off-by: Heikki Krogerus<heikki.krogerus@nokia.com>
> ---
>   drivers/power/isp1704_charger.c |   17 +++++++++++++++++
>   1 files changed, 17 insertions(+), 0 deletions(-)

> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 77c11f1..946e43c 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -422,6 +422,23 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
>
>   	dev_info(isp->dev, "registered with product id %s\n", isp->model);
>
> +	/*
> +	 * Taking over the D+ pullup.
> +	 *
> +	 * FIXME: The device will be disconnected if the it was already
                                                      ^^^
    "the" is not needed here.

WBR, Sergei