From: Nishanth Menon <menon.nishanth@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add xM rev B to ID table
Date: Fri, 05 Nov 2010 13:54:47 -0400 [thread overview]
Message-ID: <4CD444E7.10908@gmail.com> (raw)
In-Reply-To: <1288936010-30462-2-git-send-email-jkridner@beagleboard.org>
Jason Kridner wrote, on 11/05/2010 01:46 AM:
> From: Koen Kooi<koen@dominion.thruhere.net>
>
> Patch was updated by Jason Kridner<jkridner@beagleboard.org>:
> * Use tabs to match style of other board revisions
> * Only include board revisions that exist
> * Default to the same configuration as the latest revision, but
> without setting 'beaglerev'
>
> Signed-off-by: Jason Kridner<jkridner@beagleboard.org>
not signed-off-by: Koen?
> ---
> board/ti/beagle/beagle.c | 20 +++++++++++++++++++-
> board/ti/beagle/beagle.h | 3 ++-
> 2 files changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
> index 520e57d..93c452e 100644
> --- a/board/ti/beagle/beagle.c
> +++ b/board/ti/beagle/beagle.c
> @@ -176,7 +176,7 @@ int misc_init_r(void)
> TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> TWL4030_PM_RECEIVER_DEV_GRP_P1);
> break;
> - case REVISION_XM:
> + case REVISION_XM_A:
> printf("Beagle xM Rev A\n");
> setenv("beaglerev", "xMA");
> setenv("mpurate", "1000");
> @@ -187,8 +187,26 @@ int misc_init_r(void)
> TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> TWL4030_PM_RECEIVER_DEV_GRP_P1);
> break;
> + case REVISION_XM_B:
> + printf("Beagle xM Rev B\n");
> + setenv("beaglerev", "xMB");
> + setenv("mpurate", "1000");
> + MUX_BEAGLE_XM();
> + /* Set VAUX2 to 1.8V for EHCI PHY */
> + twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VAUX2_DEDICATED,
> + TWL4030_PM_RECEIVER_VAUX2_VSEL_18,
> + TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> + TWL4030_PM_RECEIVER_DEV_GRP_P1);
> + break;
> default:
> printf("Beagle unknown 0x%02x\n", get_board_revision());
> + setenv("mpurate", "1000");
It looks to me looking at the file that mpurate usage is CPU based and
NOT board based.. maybe you should use the cpu idendity to decide on
mpurate instead?
> + MUX_BEAGLE_XM();
> + /* Set VAUX2 to 1.8V for EHCI PHY */
> + twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VAUX2_DEDICATED,
> + TWL4030_PM_RECEIVER_VAUX2_VSEL_18,
> + TWL4030_PM_RECEIVER_VAUX2_DEV_GRP,
> + TWL4030_PM_RECEIVER_DEV_GRP_P1);
> }
>
> switch (get_expansion_id()) {
> diff --git a/board/ti/beagle/beagle.h b/board/ti/beagle/beagle.h
> index 7d8dee0..fa893c4 100644
> --- a/board/ti/beagle/beagle.h
> +++ b/board/ti/beagle/beagle.h
> @@ -37,7 +37,8 @@ const omap3_sysinfo sysinfo = {
> #define REVISION_AXBX 0x7
> #define REVISION_CX 0x6
> #define REVISION_C4 0x5
> -#define REVISION_XM 0x0
> +#define REVISION_XM_A 0x0
> +#define REVISION_XM_B 0x1
>
> /*
> * IEN - Input Enable
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-11-05 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 5:46 [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more expansionboard IDs Jason Kridner
2010-11-05 5:46 ` [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add xM rev B to ID table Jason Kridner
2010-11-05 17:54 ` Nishanth Menon [this message]
2010-11-06 3:05 ` Steve Sakoman
2010-11-06 4:40 ` Nishanth Menon
2010-11-07 9:16 ` Premi, Sanjeev
2010-11-07 14:56 ` Nishanth Menon
2010-11-07 17:00 ` Steve Sakoman
2010-11-07 17:30 ` Nishanth Menon
2011-03-03 17:14 ` [U-Boot] [PATCH v2] " Jason Kridner
2011-04-18 21:36 ` Paulraj, Sandeep
2010-11-05 6:37 ` [U-Boot] [PATCH] ARMV7: OMAP3: BeagleBoard: add more expansionboard IDs Wolfgang Denk
2010-11-05 8:12 ` Premi, Sanjeev
2011-03-03 19:51 ` [U-Boot] [PATCH v2] " Jason Kridner
2011-04-18 21:37 ` Paulraj, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD444E7.10908@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.