From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] IDE: ide-floppy, remove unnecessary NULL check Date: Sat, 06 Nov 2010 15:00:01 +0300 Message-ID: <4CD54341.4050109@ru.mvista.com> References: <1289034412-24278-1-git-send-email-jslaby@suse.cz> <1289034412-24278-3-git-send-email-jslaby@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:38624 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440Ab0KFMBu (ORCPT ); Sat, 6 Nov 2010 08:01:50 -0400 In-Reply-To: <1289034412-24278-3-git-send-email-jslaby@suse.cz> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jiri Slaby Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org, Christoph Hellwig , "David S. Miller" , linux-ide@vger.kernel.org Hello. On 06-11-2010 12:06, Jiri Slaby wrote: > Stanse founf that rq in ide_floppy_callback cannot be NULL, because it found? > is dereferenced all around. So remove the superfluous check. > This appeared after blk_* macors removal. macros? > Signed-off-by: Jiri Slaby > Cc: Christoph Hellwig > Cc: "David S. Miller" > Cc: linux-ide@vger.kernel.org MBR, Sergei