From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fix load of RHEL ans SUSE images by correctly calculate ELF entry point
Date: Sat, 06 Nov 2010 20:44:04 +0100 [thread overview]
Message-ID: <4CD5B004.5040209@gmail.com> (raw)
In-Reply-To: <4CD2CB7E.4040801@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]
On 11/04/2010 04:04 PM, Manoel Rebelo Abranches wrote:
> Fixed some issues reported by Vladimir:
>
> Initial alignment value 1 instead of 0.
> Verify error by returning address being -1 since 0 may be valid in
> memory allocated directly by the Open Firmware.
> Use 'end' instead of (addr + len) to search for available memory.
> change hardcoded value '1' to GRUB_MEMORY_AVAILABLE.
>
Go ahead.
> On 10/19/2010 11:46 AM, Manoel Rebelo Abraches wrote:
>> This is another version to the same fix.
>>
>> The first patch 01_mem.patch creates a new function to allocate memory
>> using the "available" property in the "memory" node.
>> The second patch 02_offset.patch correctly finds the linux entry point,
>> also assumes that more segments can exist (made accordingly with sparc
>> implementation)
>>
>> The patch was made passing -Bbp to diff as suggested by Vladimir.
>> I tested with RHEL/SUSE images and some RHEL/SUSE kernel I had and
>> worked correctly. Before the images failed to boot.
>> Thank you for reviewing this.
>>
>> On Mon, 2010-09-27 at 04:29 -0300, Manoel Rebelo Abraches wrote:
>>> This Patch loads kernel LOAD segment at the address fixed by PhysAddr
>>> with alignment Align at the ELF program header. Even if this address is
>>> in use other address with the same alignment is found "linuxadr" (since
>>> linux can relocate itself). The linux main function is then find in the
>>> adress linuxaddr + entry + (PhysAddr- Entry), where Entry is the Entry
>>> point address in the ELF header. (PhysAddr- Entry) gives the offset
>>> where the linux entry point is located after linuxaddr.
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-11-06 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 7:29 [PATCH] fix load of RHEL ans SUSE images by correctly calculate ELF entry point Manoel Rebelo Abraches
2010-10-19 13:46 ` Manoel Rebelo Abraches
2010-11-04 15:04 ` Manoel Rebelo Abranches
2010-11-06 19:44 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD5B004.5040209@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.