From: Oliver Hartkopp <socketcan@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, drosenberg@vsecurity.com,
chas@cmf.nrl.navy.mil, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
remi.denis-courmont@nokia.com, netdev@vger.kernel.org,
security@kernel.org
Subject: Re: [Security] [SECURITY] Fix leaking of kernel heap addresses via /proc
Date: Sun, 07 Nov 2010 11:28:08 +0100 [thread overview]
Message-ID: <4CD67F38.1060506@hartkopp.net> (raw)
In-Reply-To: <20101106.165703.193714684.davem@davemloft.net>
On 07.11.2010 00:57, David Miller wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sat, 6 Nov 2010 13:50:32 -0700
>
>> On Saturday, November 6, 2010, Dan Rosenberg <drosenberg@vsecurity.com> wrote:
>>>
>>> Clearly, in most cases we cannot just remove the field from the /proc
>>> output, as this would break a number of userspace programs that rely on
>>> consistency. However, I propose that we replace the address with a "0"
>>> rather than leaking this information.
>>
>> I really think it would be much better to use the unidentified number
>> or similar.
>>
>> Just replacing with zeroes is annoying, and has the potential of
>> losing actual information.
>
> I would really like to see the specific examples of where this is
> happening, it sounds like something very silly to me.
Indeed Urs and me had a similar discussion before we decided to put different
(user relevant) content into the procfs output and break the current layout:
http://patchwork.ozlabs.org/patch/70282/
The layout break was ok in this case as the people using the CAN procfs stuff
do this only when facing problems (with their applications) at runtime.
A discussed approach that won't break the procfs layout was to set the values
to "0" and only fill them with real content depending on CONFIG_DEBUG_INFO .
Would that fit here?
Or maybe a different config option CONFIG_DEBUG_KERNEL_ADDR would do the job,
as i don't know which distros enable CONFIG_DEBUG_INFO by default ...
Regards,
Oliver
next prev parent reply other threads:[~2010-11-07 10:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 20:11 [SECURITY] Fix leaking of kernel heap addresses via /proc Dan Rosenberg
2010-11-06 20:50 ` [Security] " Linus Torvalds
2010-11-06 23:48 ` Ted Ts'o
2010-11-07 21:52 ` Andi Kleen
2010-11-07 22:48 ` Chas Williams (CONTRACTOR)
2010-11-07 23:14 ` Andi Kleen
2010-11-07 23:22 ` Linus Torvalds
2010-11-07 23:29 ` Andi Kleen
2010-11-07 23:27 ` Dan Rosenberg
2010-11-07 23:56 ` Andi Kleen
2010-11-08 2:01 ` David Miller
2010-11-08 7:33 ` Eric Dumazet
2010-11-08 9:43 ` Andi Kleen
2010-11-08 10:14 ` Eric Dumazet
2010-11-06 23:57 ` David Miller
2010-11-07 10:28 ` Oliver Hartkopp [this message]
2010-11-07 17:11 ` Ben Hutchings
2010-11-08 1:00 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD67F38.1060506@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=remi.denis-courmont@nokia.com \
--cc=security@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.