From: Jeff Garzik <jeff@garzik.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] SCSI host lock push-down
Date: Sun, 07 Nov 2010 11:57:03 -0500 [thread overview]
Message-ID: <4CD6DA5F.3050905@garzik.org> (raw)
In-Reply-To: <4CD66222.5040808@panasas.com>
On 11/07/2010 03:24 AM, Boaz Harrosh wrote:
> Well now isn't that simple? One nit for me though.
> I would like to see a more scary name for above something like:
> DEF_SCSI_QCMD_WITH_LOCKING or
> DEF_SCSI_QCMD_OLD_WAY
I don't have a real preference; whatever the community prefers. Maybe I
would suggest DEF_SCSI_QCMD_LOCKER.
> Something that calls for a cleanup and removal the first time
> the driver is touched.
>
> Otherwise I think this is the only form that should make it safe
> for this Kernel.
>
> (The rename could be nice also though it is one additional hunk in
> each driver. Did you use a script to produce this?)
No script; a few vim macros helped a bit. I wanted to actually examine
each callsite, to get a feel of the locking scheme, and make sure my
change was truly an equivalent-transformation.
Jeff
next prev parent reply other threads:[~2010-11-07 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 0:24 [RFC PATCH] SCSI host lock push-down Jeff Garzik
2010-11-06 9:31 ` Stefan Richter
2010-11-07 16:54 ` Jeff Garzik
2010-11-07 8:24 ` Boaz Harrosh
2010-11-07 16:57 ` Jeff Garzik [this message]
2010-11-07 12:56 ` Andi Kleen
2010-11-09 1:28 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD6DA5F.3050905@garzik.org \
--to=jeff@garzik.org \
--cc=bharrosh@panasas.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.