Re: [PATCH 0/3] git-pull: new pull request generation and sending scripts

[Darren Hart <dvhart@linux.intel.com>]

On 11/08/2010 04:33 PM, Saul Wold wrote:
> On 11/08/2010 07:59 AM, Darren Hart wrote:

Hey Saul,

Thanks for the review!

> I think we also need a way to only send the initial email (and not the
> patches) since I work with the team to pull together multiple patches
> that are already on the list and re-send the request to the Yocto alias,
> I don't want to flood the list with duplicate match info.

This is really no different that it was originally. Just load the 
0000-cover-letter.txt into your favorite MUA and send away. 
Alternatively, you can just delete the other messages and use 
send-pull-request.sh.

I'd rather not make an option that makes it easy for people to not send 
the patches, as it may become the norm (as that is the habit people are 
already in). Will one of the options I mentioned work for you?

>
> Also on a minor nit note: can you change the Branch to include contrib/
> that way it can be a cut and paste for doing some of the local git
> operations.

The name "contrib" is user defined and cannot be relied upon to be the 
same on every system. The branch is relative to the poky-contrib.git 
repository, prepending "contrib" wouldn't be accurate.


>> Excellent - and this brings up a point I wanted to discuss. One of the
>> stated reasons for doing this was to facilitate peer review. Now that I
>> have Bruce's Acked-by:, I could reword the commit messages to include
>> them, or Richard could add them when he does the pull, but I do think
>> they should be present in the final commits to poky proper.
>>
> I am not sure we need to get into updating the patch or commit messages
> with Acked-by lines, the email archives should suffice.

It can be difficult to map commits to email threads, and when the ack 
occurs elsewhere, the history is completely lost. We don't need to track 
every "I like this patch", but I believe it is good practice to track 
key Acks from key reviewers.

Thanks,

-- 
Darren Hart
Embedded Linux Kernel