From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=32939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFnZG-0007Gv-Fe for qemu-devel@nongnu.org; Tue, 09 Nov 2010 07:44:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFnZE-0005cQ-PW for qemu-devel@nongnu.org; Tue, 09 Nov 2010 07:44:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFnZE-0005c8-GI for qemu-devel@nongnu.org; Tue, 09 Nov 2010 07:44:52 -0500 Message-ID: <4CD94240.8060308@redhat.com> Date: Tue, 09 Nov 2010 13:44:48 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] pc: Fix e820 fw_cfg for big endian References: <20101108035143.26532.81891.stgit@s20.home> <4CD92933.6060900@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: blauwirbel@gmail.com, Alex Williamson , qemu-devel@nongnu.org On 11/09/10 13:42, Alexander Graf wrote: > > On 09.11.2010, at 11:57, Jes Sorensen wrote: > >> On 11/08/10 04:57, Alex Williamson wrote: >>> Signed-off-by: Alex Williamson >>> --- >>> >>> Compile tested only. Only current user is kvm, no cross-arch users. >>> >>> hw/pc.c | 14 +++++++------- >>> 1 files changed, 7 insertions(+), 7 deletions(-) >> >> Patch looks fine to me, but are there any systems out there using e820 >> on big endian hardware? > > This fixes things when host endianness is big endian. Ah right, then it's all fine :) Cheers, Jes