From: Jens Axboe <jaxboe@fusionio.com>
To: "paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>
Cc: Daniel J Blueman <daniel.blueman@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.37-rc1] sys_ioprio_set and RCU locking...
Date: Tue, 9 Nov 2010 21:35:10 +0100 [thread overview]
Message-ID: <4CD9B07E.70502@fusionio.com> (raw)
In-Reply-To: <4CD80162.9000607@fusionio.com>
On 2010-11-08 14:55, Jens Axboe wrote:
>>>>> Take the RCU lock for read across acquiring the pointer to the task
>>>>> credentials and dereferencing it.
>>>>
>>>> Jens, does this look sane?
>>>
>>> Yes, looks clean enough to me.
>>
>> Very good! Are you willing to take the patch in your tree?
>
> Certainly, I'm in the middle of patch monkeying now anyway. Will queue
> it up.
The patch was buggy, I discovered that it does not do the proper
RCU unlock if we fail the uid match. Merged version here:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=1a882abdbf9579ad0e5655f928e4ede30db301e6
--
Jens Axboe
next prev parent reply other threads:[~2010-11-09 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 12:15 [2.6.37-rc1] sys_ioprio_set and RCU locking Daniel J Blueman
2010-11-07 18:54 ` Paul E. McKenney
2010-11-08 13:28 ` Jens Axboe
2010-11-08 13:52 ` Paul E. McKenney
2010-11-08 13:55 ` Jens Axboe
2010-11-09 20:35 ` Jens Axboe [this message]
2010-11-09 21:49 ` Daniel J Blueman
2010-11-09 21:50 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD9B07E.70502@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=daniel.blueman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.