Re: Source code of SMB2 Kernel module

[Shinnosuke Yagi <yagi.shinnosuke-o7dWnD6vFTHqq2nvvmkE/A@public.gmane.org>]

I added some logging messages.

====================================================

# git diff fs/smb2/smb2fs.c
diff --git a/fs/smb2/smb2fs.c b/fs/smb2/smb2fs.c
index aa550a3..52c9f35 100644
--- a/fs/smb2/smb2fs.c
+++ b/fs/smb2/smb2fs.c
@@ -57,7 +57,7 @@ static struct quotactl_ops smb2_quotactl_ops;

  /* Definitions of various global variables follow */

-int smb2FYI;
+int smb2FYI = 1;
  int smb2ERROR = 1;
  int trace_SMB2;

@@ -1059,14 +1059,19 @@ init_smb2(void)
                 goto out_destroy_inodecache;

         rc = smb2_init_request_bufs();
-       if (rc)
+           sFYI(1, "smb2_init_request_bufs %d", rc);
+       if (rc){
                 goto out_destroy_mids;
+    }

         rc = register_filesystem(&smb2_fs_type);
-       if (rc)
+           sFYI(1, "register_filesystem %d", rc);
+       if (rc){
                 goto out_destroy_request_bufs;
+    }

         rc = register_key_type(&smb2_spnego_key_type);
+           sFYI(1, "register_key_type %d", rc);
         if (rc)
                 goto out_unregister_filesystem;

====================================================




I got following logs on dmesg.
====================================================
FS-Cache: Netfs 'smb2' registered for caching
fs/smb2/smb2fs.c: SMB2_max_buf_size 0x4000
fs/smb2/smb2fs.c: smb2_init_request_bufs 0
fs/smb2/smb2fs.c: register_filesystem 0
fs/smb2/smb2fs.c: register_key_type -17
FS-Cache: Netfs 'smb2' unregistered from caching
====================================================

register_key_types returned -17 (EEXIST)

key "smb2" has already registered?

What should I do?

(2010/11/09 13:05), Steve French wrote:
> On Mon, Nov 8, 2010 at 9:49 PM, Shinnosuke Yagi
> <yagi.shinnosuke-o7dWnD6vFTHqq2nvvmkE/A@public.gmane.org>  wrote:
>> Thank you, Suresh and Steve.
>>
>>
>> Fscache was loaded, but smb2 module was not loaded successfully.
>> Nothing was displayed when I did
>>>
>>>    lsmod | grep smb2
>>
>>  From Dmesg, following messages were displayed.
>> ====================================================
>> FS-Cache: Netfs 'smb2' registered for caching
>> FS-Cache: Netfs 'smb2' unregistered from caching
>> ====================================================
>>
>> Does this means FS-Cache on this kernel doesn't support smb2?
>
> That is probably not the problem.   Seems like init_smb2 is failing.
> Perhaps a problem registering the required key types.
>
> You could enable debug messages to see if additional info is logged
> to dmesg
>
> e.g.
>
> stevef@stevef-laptop:~/smb2$ git diff -a
> diff --git a/fs/smb2/smb2fs.c b/fs/smb2/smb2fs.c
> index aa550a3..8cc1245 100644
> --- a/fs/smb2/smb2fs.c
> +++ b/fs/smb2/smb2fs.c
> @@ -57,7 +57,7 @@ static struct quotactl_ops smb2_quotactl_ops;
>
>   /* Definitions of various global variables follow */
>
> -int smb2FYI;
> +int smb2FYI = 1;
>   int smb2ERROR = 1;
>   int trace_SMB2;
>
>
>
> Alternatively you could add some logging (e.g. printk statements)
> to the error goto statements in this section of smb2fs.c (smb2_init)
>
>          rc = smb2_fscache_register();
>          if (rc)
>                  goto out_clean_proc;
>
>          rc = smb2_init_inodecache();
>          if (rc)
>                  goto out_unregister_fsc;
>
>          rc = smb2_init_mids();
>          if (rc)
>                  goto out_destroy_inodecache;
>
>          rc = smb2_init_request_bufs();
>          if (rc)
>                  goto out_destroy_mids;
>
>          rc = register_filesystem(&smb2_fs_type);
>          if (rc)
>                  goto out_destroy_request_bufs;
>
>          rc = register_key_type(&smb2_spnego_key_type);
>
>
>
---------