All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: Patch IMX audmux debugfs.
Date: Wed, 10 Nov 2010 14:19:05 +0300	[thread overview]
Message-ID: <4CDA7FA9.3020100@ru.mvista.com> (raw)
In-Reply-To: <BLU0-SMTP14C9A6CEFEB68711495B30B8300@phx.gbl>

Hello.

On 10-11-2010 2:11, Bill Pringlemeir wrote:

> $ mount -t debugfs debugfs /sys/kernel/debug
> $ cd /sys/kernel/debug/audmux
> $ cat *
> [crashes when accessing ssi7]

> The index is one based, but the register map is zero based.  So the
> ssi1 is actually sending info for ssi2.  Also, the ssi7 touches
> non-existent data and can cause an exception (only registers sets 1-6
> exist).

> Alternatively, the MX31_AUDMUX_PORT6_SSI_PINS_6 and
> MX27_AUDMUX_PPCR3_SSI_PINS_3 constants could be used for the loop
> termination, but maybe that means conditionalization (and there are no
> MX25 constants).

> diff --git a/arch/arm/plat-mxc/audmux-v2.c b/arch/arm/plat-mxc/audmux-v2.c
> index f9e7cdb..0547145 100644
> --- a/arch/arm/plat-mxc/audmux-v2.c
> +++ b/arch/arm/plat-mxc/audmux-v2.c
> @@ -66,7 +66,7 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf,
>   {
>          ssize_t ret;
>          char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
> -       int port = (int)file->private_data;
> +       int port = ((int)file->private_data) - 1;

    Parens around typecast not necessary.

WBR, Sergei

  reply	other threads:[~2010-11-10 11:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 23:11 Patch IMX audmux debugfs Bill Pringlemeir
2010-11-10 11:19 ` Sergei Shtylyov [this message]
2010-11-10 15:26 ` Sascha Hauer
2010-11-11 16:38   ` Bill Pringlemeir
2010-11-12  7:17     ` Sascha Hauer
2010-11-12 11:49       ` Mark Brown
2010-11-14 20:15         ` Bill Pringlemeir
     [not found]         ` <87oc9rk6fe.fsf@sympatico.ca>
2010-11-15 15:09           ` [Patch v3] Fix audmuxv2 debugfs indexing. [was: Patch IMX audmux debugfs.] Bill Pringlemeir
2010-11-15 15:30             ` Mark Brown
2010-11-15 15:53               ` [Patch v3] Fix audmuxv2 debugfs indexing Bill Pringlemeir
     [not found]               ` <87oc9qeg75.fsf@sympatico.ca>
2010-11-15 16:10                 ` Bill Pringlemeir
2010-11-15 16:26                   ` Mark Brown
2010-11-15 18:17                     ` Bill Pringlemeir
     [not found]                     ` <8762vy4fki.fsf@sympatico.ca>
2010-11-19 15:47                       ` Bill Pringlemeir
     [not found]                       ` <87r5ehuxh5.fsf@sympatico.ca>
2010-11-30 21:07                         ` Bill Pringlemeir
     [not found]           ` <87zktavd2f.fsf_-_@sympatico.ca>
2010-11-15 15:24             ` Bill Pringlemeir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDA7FA9.3020100@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.