From: Ryan Mallon <ryan@bluewatersys.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Sedji Gaouaou <sedji.gaouaou@atmel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
gwossum@acm.org
Subject: Re: [PATCH] Fix Atmel soc audio boards Kconfig dependency
Date: Thu, 11 Nov 2010 10:54:08 +1300 [thread overview]
Message-ID: <4CDB1480.3080109@bluewatersys.com> (raw)
In-Reply-To: <1289423099.3284.52.camel@odin>
On 11/11/2010 10:04 AM, Liam Girdwood wrote:
> On Thu, 2010-11-11 at 09:02 +1300, Ryan Mallon wrote:
>
>> Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
>> audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing
>> clk_set_parent and clk_set_rate when building without
>> AT91_PROGRAMMABLE_CLOCKS.
>>
>> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
>>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
Just realised that the PlayPaq board only appears in the sound/soc/atmel
directory. I cannot find a board file for it under either
arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes
the dependency for the SAM9G20-EK board since I think the PlayPaq is
actually AVR32, and therefore should not depend on
AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
---
Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC
audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and
clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
---
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index e720d5e..a614181 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -16,7 +16,8 @@ config SND_ATMEL_SOC_SSC
config SND_AT91_SOC_SAM9G20_WM8731
tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation board"
- depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC
+ depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC && \
+ AT91_PROGRAMMABLE_CLOCKS
select SND_ATMEL_SOC_SSC
select SND_SOC_WM8731
help
next prev parent reply other threads:[~2010-11-10 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:02 [PATCH] Fix Atmel soc audio boards Kconfig dependency Ryan Mallon
2010-11-10 21:04 ` Liam Girdwood
2010-11-10 21:54 ` Ryan Mallon [this message]
2010-11-10 23:09 ` Geoffrey Wossum
2010-11-11 11:42 ` Liam Girdwood
2010-11-11 14:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDB1480.3080109@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gwossum@acm.org \
--cc=lrg@slimlogic.co.uk \
--cc=sedji.gaouaou@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.