Re: [PULL] Add sanity test cases for scp/shutdown

[Darren Hart <dvhart@linux.intel.com>]

On 11/10/2010 07:58 PM, Xu, Jiajun wrote:

Hi Jiajun,

The *** BLURB HERE *** token is meant to be replaced with a description 
of what the following patches address. Without the blurb (and without 
the patch itself) there is very little information in this email about 
what is being changed.

> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: jxu49/master
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jxu49/master
>
> Thanks,
>      Jiajun Xu<jiajun.xu@intel.com>
> ---
>
> Jiajun Xu (1):
>    imagetest-qemu: Add sanity test cases for scp/shutdown in target

This patch should have followed as a response to this cover letter, but 
I haven't seen it arrive in my inbox. Did you send the request using the 
send-pull-request.sh script? If not, please do in the future, as having 
the patches hit the list makes it much easier for others to review - and 
more reviews means better code.

Looking at the diffstat below, my first thought is that this should 
probably be at least 2 patches, possibly more. At least one patch per test.

And thanks for being the first to use the new create-pull-request.sh 
besides me! ;-)

--
Darren

>
>   meta/classes/imagetest-qemu.bbclass                |    2 +-
>   scripts/qemuimage-testlib                          |    4 +-
>   scripts/qemuimage-tests/sanity/boot                |    2 +-
>   scripts/qemuimage-tests/sanity/dmesg               |    2 +-
>   scripts/qemuimage-tests/sanity/scp                 |   71 ++++++++++++++++++++
>   scripts/qemuimage-tests/sanity/shutdown            |   70 +++++++++++++++++++
>   scripts/qemuimage-tests/sanity/ssh                 |    2 +-
>   .../scenario/qemuarm/poky-image-sato               |    2 +
>   .../scenario/qemuarm/poky-image-sdk                |    2 +
>   .../scenario/qemumips/poky-image-sato              |    2 +
>   .../scenario/qemumips/poky-image-sdk               |    2 +
>   .../scenario/qemuppc/poky-image-sato               |    2 +
>   .../scenario/qemuppc/poky-image-sdk                |    2 +
>   .../scenario/qemux86-64/poky-image-minimal         |    1 +
>   .../scenario/qemux86-64/poky-image-sato            |    5 ++
>   .../scenario/qemux86-64/poky-image-sdk             |    5 ++
>   .../scenario/qemux86/poky-image-sato               |    2 +
>   .../scenario/qemux86/poky-image-sdk                |    2 +
>   18 files changed, 175 insertions(+), 5 deletions(-)
>   create mode 100755 scripts/qemuimage-tests/sanity/scp
>   create mode 100755 scripts/qemuimage-tests/sanity/shutdown
>   create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-minimal
>   create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-sato
>   create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-sdk
>
> Best Regards,
> Jiajun
>
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky


-- 
Darren Hart
Embedded Linux Kernel