From: Jeff Garzik <jeff@garzik.org>
To: Phillip Susi <psusi@cfl.rr.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] Export ahci eSATA attribute
Date: Thu, 11 Nov 2010 00:06:18 -0500 [thread overview]
Message-ID: <4CDB79CA.6000606@garzik.org> (raw)
In-Reply-To: <4CDB63E7.1040106@cfl.rr.com>
> +++ b/include/linux/libata.h
> @@ -203,6 +203,7 @@ enum {
> * management */
> ATA_FLAG_SW_ACTIVITY = (1 << 22), /* driver supports sw activity
> * led */
> + ATA_FLAG_EXTERN = (1 << 23), /* eSATA external port */
>
> /* bits 24:31 of ap->flags are reserved for LLD specific flags */
hmmm, I don't think we need a libata-wide flag just for an AHCI-specific
attribute. Certainly eSATA exists elsewhere, but so far this is just
for print-out purposes, and so, seems wasteful.
Jeff
next prev parent reply other threads:[~2010-11-11 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:32 [PATCH] Export ahci eSATA attribute Phillip Susi
2010-11-11 5:06 ` Jeff Garzik [this message]
2010-11-12 15:04 ` Phillip Susi
2010-11-13 5:23 ` Phillip Susi
2010-11-13 5:30 ` Jeff Garzik
2010-11-13 15:46 ` Phillip Susi
2010-11-18 19:37 ` Phillip Susi
2011-01-20 16:08 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDB79CA.6000606@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=psusi@cfl.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.