From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47184 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGT6q-0006yj-O4
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:06:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tamura.yoshiaki@lab.ntt.co.jp>) id 1PGT6n-0002XC-1o
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:06:20 -0500
Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:56343)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tamura.yoshiaki@lab.ntt.co.jp>) id 1PGT6m-0002Vk-D1
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:06:17 -0500
Message-ID: <4CDBB1FA.1010402@lab.ntt.co.jp>
Date: Thu, 11 Nov 2010 18:06:02 +0900
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
MIME-Version: 1.0
References: <20101108190253.560821111@redhat.com>
	<4CD8E3E4.8010500@lab.ntt.co.jp> <20101109130843.GA24340@amt.cnet>
In-Reply-To: <20101109130843.GA24340@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch 0/3] block migration fixes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org, Liran Schour <LIRANS@il.ibm.com>

Marcelo Tosatti wrote:
> On Tue, Nov 09, 2010 at 03:02:12PM +0900, Yoshiaki Tamura wrote:
>> Marcelo Tosatti wrote:
>>> Following patchset fixes block migration corruption issues.
>>
>> Hi Marcelo,
>>
>> Thanks for looking into this issue.  Although we tried your patches, we're still
>> seeing the corruption.  If we execute block migration while copying a file
>> locally, md5sum of the copied file doesn't match with the original.  Sometimes,
>> the filesystem returns an I/O error.
>>
>> Could you let us know how you tested and debugged?  Did you use blkverify?
>
> Yoshiaki,
>
> I first reproduced corruption by copying a large file during "migrate
> -i", with shared base on qcow2 filesystem, as in your original report.
>
> To debug the problem, file with different byte pattern at every 1MB
> (size of dirty chunk) was created and copied directly to an IDE disk in
> the guest. Raw format used for the disk image.
>
> With this patchset, i'm not able to reproduce the original issue
> anymore.
>
> Can you please provide more details on how to reproduce?

Marcelo,

We double checked and the patchset does seem to fix the problem.  The was a 
mistake in our test procedure.  Sorry for the confusion.

Thanks,

Yoshi