From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command
Date: Thu, 11 Nov 2010 10:58:15 -0600 [thread overview]
Message-ID: <4CDC20A7.5070307@codemonkey.ws> (raw)
In-Reply-To: <20101111163952.GN22152@redhat.com>
On 11/11/2010 10:39 AM, Daniel P. Berrange wrote:
> IIUC, the FDs sent/received via struct cmsghdr are in a strictly
> ordered array, so why not just define a placeholder syntax for
> the commands that maps to the array indexes. eg
>
> netdev_add tap,fd=$0,vhost_fd=$1,id=hostnet0
>
> The '$' sign is not valid for a normal FD number, so use of a $0,
> $1, $2, etc can reliably be substituted with the real FD number from
> the cmsghdr array elements 0, 1, 2, etc
>
Character devices are streaming so it's hard to refer to array indexes
in a single message. You could count it for the entire session but
session boundaries aren't really well defined.
I don't think it's an obvious win.
Regards,
Anthony Liguori
> Regards,
> Daniel
>
next prev parent reply other threads:[~2010-11-11 16:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 14:28 [Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough Luiz Capitulino
2010-10-29 14:28 ` [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Buffered driver Luiz Capitulino
2010-10-29 14:28 ` [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command Luiz Capitulino
2010-11-10 13:20 ` Markus Armbruster
2010-11-10 13:36 ` Luiz Capitulino
2010-11-11 15:47 ` Markus Armbruster
2010-11-11 15:55 ` Daniel P. Berrange
2010-11-11 16:30 ` Anthony Liguori
2010-11-11 16:39 ` Daniel P. Berrange
2010-11-11 16:47 ` Luiz Capitulino
2010-11-11 16:58 ` Anthony Liguori [this message]
2010-11-11 16:55 ` Luiz Capitulino
2010-11-11 16:59 ` Anthony Liguori
2010-11-11 17:45 ` Markus Armbruster
2010-10-29 14:28 ` [Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode Luiz Capitulino
2010-11-10 13:22 ` Markus Armbruster
2010-11-11 16:22 ` [Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough Avi Kivity
2010-11-11 16:24 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2010-11-10 18:59 [Qemu-devel] [PATCH v2 " Luiz Capitulino
2010-11-10 18:59 ` [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command Luiz Capitulino
2010-11-11 15:47 ` Markus Armbruster
2010-11-11 17:11 ` Luiz Capitulino
2010-11-11 19:31 [Qemu-devel] [PATCH v3 0/3]: QMP: Human Monitor passthrough Luiz Capitulino
2010-11-11 19:31 ` [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command Luiz Capitulino
2010-11-16 19:19 [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough Luiz Capitulino
2010-11-16 19:19 ` [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDC20A7.5070307@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.