From: Jeff Garzik <jeff@garzik.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@suse.de>,
Christoph Hellwig <hch@lst.de>,
Mike Christie <michaelc@cs.wisc.edu>,
Ravi Anand <ravi.anand@qlogic.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Joe Eykholt <jeykholt@cisco.com>,
James Smart <james.smart@emulex.com>,
Vasu Dev <vasu.dev@linux.intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>, Tejun Heo <tj@kernel.org>,
Mike Anderson <andmike@linux.vnet.ibm.com>,
MPTFusionLinux <DL-MPTFusionLinux@lsi.com>
Subject: Re: [PATCH 02/11] libata: Convert to host_lock less w/ interrupts disabled internally
Date: Thu, 11 Nov 2010 22:47:13 -0500 [thread overview]
Message-ID: <4CDCB8C1.6000303@garzik.org> (raw)
In-Reply-To: <1289520817-16458-1-git-send-email-nab@linux-iscsi.org>
On 11/11/2010 07:13 PM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger<nab@linux-iscsi.org>
>
> This patch changes ata_scsi_queuecmd_lck() to a host lock less
> ata_scsi_queuecmd() that will disable interrupts internally using
> ap->lock and drops the now legacy host_lock unlock.
>
> Signed-off-by: Nicholas A. Bellinger<nab@linux-iscsi.org>
> ---
> drivers/ata/libata-scsi.c | 14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index a007c36..9614758 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -3173,25 +3173,22 @@ static inline int __ata_scsi_queuecmd(struct scsi_cmnd *scmd,
> * SCSI commands. This creates the overall effect of
> * ATA and ATAPI devices appearing as SCSI devices.
> *
> - * LOCKING:
> - * Releases scsi-layer-held lock, and obtains host lock.
> - *
The code appears correct but the comment removal is not.
Locking has not disappeared, and the ATA host lock continues to be obtained.
next prev parent reply other threads:[~2010-11-12 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 0:13 [PATCH 02/11] libata: Convert to host_lock less w/ interrupts disabled internally Nicholas A. Bellinger
2010-11-12 3:47 ` Jeff Garzik [this message]
2010-11-12 4:54 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDCB8C1.6000303@garzik.org \
--to=jeff@garzik.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=ak@linux.intel.com \
--cc=andmike@linux.vnet.ibm.com \
--cc=andrew.vasquez@qlogic.com \
--cc=hch@lst.de \
--cc=james.smart@emulex.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=ravi.anand@qlogic.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=vasu.dev@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.