From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH v2 2/5] KVM: MMU: clear apfs if page state is changed
Date: Fri, 12 Nov 2010 14:47:01 +0800 [thread overview]
Message-ID: <4CDCE2E5.6000401@cn.fujitsu.com> (raw)
In-Reply-To: <4CDCE2B0.7000601@cn.fujitsu.com>
If CR0.PG is changed, the page fault cann't be avoid when the prefault address
is accessed later
And it also fix a bug: it can retry a page enabled #PF in page disabled context
if mmu is shadow page
This idear is from Gleb Natapov
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
arch/x86/kvm/x86.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index fc29223..c071d73 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -525,6 +525,9 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
kvm_x86_ops->set_cr0(vcpu, cr0);
+ if ((cr0 ^ old_cr0) & X86_CR0_PG)
+ kvm_clear_async_pf_completion_queue(vcpu);
+
if ((cr0 ^ old_cr0) & update_bits)
kvm_mmu_reset_context(vcpu);
return 0;
--
1.7.0.4
next prev parent reply other threads:[~2010-11-12 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 6:46 [PATCH v2 1/5] KVM: MMU: fix missing post sync audit Xiao Guangrong
2010-11-12 6:47 ` Xiao Guangrong [this message]
2010-11-12 6:49 ` [PATCH v2 3/5] KVM: MMU: support apf for nonpaing guest Xiao Guangrong
2010-11-12 6:49 ` [PATCH v2 4/5] KVM: MMU: fix apf prefault if nested guest is enabled Xiao Guangrong
2010-11-12 6:50 ` [PATCH v2 5/5] KVM: MMU: retry #PF for softmmu Xiao Guangrong
2010-11-14 10:46 ` Avi Kivity
2010-11-15 5:25 ` Xiao Guangrong
2010-11-15 9:30 ` Avi Kivity
2010-11-15 9:55 ` Xiao Guangrong
2010-11-15 9:56 ` Gleb Natapov
2010-11-15 9:59 ` Avi Kivity
2010-11-15 10:12 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDCE2E5.6000401@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.